Issue 9328024: Merge 7712 - Ensure super instructions are marked during dynamic code modification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9328024: Merge 7712 - Ensure super instructions are marked during dynamic code modification. (Closed)

Created:
8 years, 10 months ago by Nick Bray (chromium)

Modified:
8 years, 10 months ago

Reviewers:

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/branches/963/src/native_client/

Visibility:
Public.

More Reviews

Description

Merge 7712 - Ensure super instructions are marked during dynamic code modification. Writing tests for this change entailed fixing a bug in the x86-32 validator where code starting with a super instruction would be incorrectly rejected during dynamic code modification due to a missing initialization. BUG= http://code.google.com/p/nativeclient/issues/detail?id=2563 TEST= ./scons platform=(x86-32|x86-64) run_dynamic_modify_test Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=7734

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+172 lines, -30 lines)			Patch
M	src/trusted/validator/x86/decoder/nc_inst_state_internal.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/trusted/validator/x86/decoder/nc_inst_state_statics.c	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/trusted/validator/x86/ncval_reg_sfi/nc_jumps.c	View		1 chunk	+12 lines, -2 lines	0 comments	Download
M	src/trusted/validator/x86/ncval_reg_sfi/ncvalidate_iter.c	View		1 chunk	+3 lines, -6 lines	0 comments	Download
M	src/trusted/validator/x86/ncval_seg_sfi/ncdecode.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/trusted/validator/x86/ncval_seg_sfi/ncdecode.c	View		3 chunks	+3 lines, -2 lines	0 comments	Download
M	src/trusted/validator/x86/ncval_seg_sfi/ncvalidate.c	View	1	5 chunks	+22 lines, -17 lines	0 comments	Download
M	tests/dynamic_code_loading/dynamic_modify_test.c	View		3 chunks	+59 lines, -1 line	0 comments	Download
M	tests/dynamic_code_loading/templates.h	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	tests/dynamic_code_loading/templates_x86.S	View		2 chunks	+57 lines, -1 line	0 comments	Download