Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(996)

Unified Diff: sky/specs/elements.md

Issue 932783004: Specs: make the change callbacks all be consistently past tense ('changed') (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/specs/elements.md
diff --git a/sky/specs/elements.md b/sky/specs/elements.md
index 140b4391aaccf2c3ee2430ca138bd7aa6b1cc61d..07b3633a16c92142094708d4424cf809dc1eab98 100644
--- a/sky/specs/elements.md
+++ b/sky/specs/elements.md
@@ -84,7 +84,7 @@ abstract class Node extends EventTarget {
// this is why insertBefore(), append(), et al, are O(N) -- the whole affected subtree is walked
// mutating the element tree from within this is strongly discouraged, since it will result in the
// callbacks being invoked while the element tree is in a different state than implied by the callbacks
- external void parentChangeCallback(ParentNode oldParent, ParentNode newParent); // O(N) in descendants
+ external void parentChangedCallback(ParentNode oldParent, ParentNode newParent); // O(N) in descendants
// default implementation calls attached/detached
void attachedCallback() { }
void detachedCallback() { }
@@ -242,7 +242,7 @@ abstract class Element extends ParentNode {
// returns the shadow root
void endTagParsedCallback() { }
- void attributeChangeCallback(String name, String oldValue, String newValue) { }
+ void attributeChangedCallback(String name, String oldValue, String newValue) { }
// name will never be null when this is called by sky
// TODO(ianh): does a node ever need to know when it's been redistributed?
@@ -261,7 +261,7 @@ class Text extends Node {
external String get value; // O(1)
external void set (String value); // O(1)
- void valueChangeCallback(String oldValue, String newValue) { }
+ void valueChangedCallback(String oldValue, String newValue) { }
@override
Type getLayoutManager() => TextLayoutManager; // O(1)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698