Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 932773002: Support V8 code caching for imported scripts in ServiceWorker (Closed)

Created:
5 years, 10 months ago by horo
Modified:
5 years, 10 months ago
Reviewers:
kinuko
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, kinuko+worker_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Support V8 code caching for imported scripts in ServiceWorker. This cl depends on https://codereview.chromium.org/929953002/ BUG=449895 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190414

Patch Set 1 #

Patch Set 2 : use WorkerGlobalScope::createWorkerScriptCachedMetadataHandler #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M Source/core/workers/WorkerGlobalScope.h View 1 3 chunks +3 lines, -0 lines 0 comments Download
M Source/core/workers/WorkerGlobalScope.cpp View 1 3 chunks +5 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
horo
kinuko@ Could you please review this?
5 years, 10 months ago (2015-02-18 06:14:49 UTC) #2
kinuko
lgtm
5 years, 10 months ago (2015-02-18 08:26:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/932773002/20001
5 years, 10 months ago (2015-02-18 10:13:57 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 12:13:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190414

Powered by Google App Engine
This is Rietveld 408576698