Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 932763002: Cleanup: Remove webkit_builder_win target. (Closed)

Created:
5 years, 10 months ago by tfarina
Modified:
5 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove webkit_builder_win target. Nobody seems to be using this target and it seems to be just an alias for blink_tests: https://code.google.com/p/chromium/codesearch#search/&q=webkit_builder_win&sq=package:chromium&type=cs BUG=None TEST=trybots R=thakis@chromium.org Committed: https://crrev.com/74126f4a63e94878ce3aeda6160ffe7b6d8a9d63 Cr-Commit-Position: refs/heads/master@{#316592}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M build/all.gyp View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
tfarina
5 years, 10 months ago (2015-02-17 03:05:18 UTC) #1
Nico
lgtm!
5 years, 10 months ago (2015-02-17 16:30:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/932763002/1
5 years, 10 months ago (2015-02-17 16:31:14 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 17:11:46 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 17:12:43 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/74126f4a63e94878ce3aeda6160ffe7b6d8a9d63
Cr-Commit-Position: refs/heads/master@{#316592}

Powered by Google App Engine
This is Rietveld 408576698