Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 932723003: flip stroke to chrome compatible define (Closed)

Created:
5 years, 10 months ago by caryclark
Modified:
5 years, 10 months ago
Reviewers:
f(malita), reed2, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

flip stroke to chrome compatible define Committed: https://skia.googlesource.com/skia/+/1297ecfd1d1efaeee41153e491b160228ba4345a

Patch Set 1 #

Patch Set 2 : fix fuzzer bugs #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+746 lines, -51 lines) Patch
M gm/bitmapshader.cpp View 1 1 chunk +2 lines, -3 lines 0 comments Download
M gm/circularclips.cpp View 1 2 chunks +2 lines, -3 lines 0 comments Download
M gm/complexclip2.cpp View 1 2 chunks +4 lines, -2 lines 0 comments Download
M gm/picture.cpp View 1 1 chunk +7 lines, -1 line 0 comments Download
M gm/pictureshader.cpp View 1 1 chunk +6 lines, -4 lines 0 comments Download
M gm/shadows.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M gm/simpleaaclip.cpp View 1 2 chunks +3 lines, -1 line 0 comments Download
M gm/strokes.cpp View 1 2 chunks +2 lines, -3 lines 0 comments Download
M gyp/SampleApp.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkPath.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M samplecode/SamplePathEffects.cpp View 1 2 chunks +4 lines, -1 line 0 comments Download
A samplecode/SamplePathFuzz.cpp View 1 2 1 chunk +650 lines, -0 lines 0 comments Download
M samplecode/SampleStrokePath.cpp View 1 2 chunks +2 lines, -3 lines 0 comments Download
M samplecode/SampleTextOnPath.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkPath.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkStroke.cpp View 1 2 8 chunks +27 lines, -26 lines 0 comments Download
M tests/StrokeTest.cpp View 1 2 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
caryclark
5 years, 10 months ago (2015-02-23 21:57:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/932723003/1
5 years, 10 months ago (2015-02-24 12:11:40 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-24 12:11:41 UTC) #5
reed2
lgtm
5 years, 10 months ago (2015-02-24 14:01:47 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 14:02:12 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1297ecfd1d1efaeee41153e491b160228ba4345a

Powered by Google App Engine
This is Rietveld 408576698