Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 932723002: Land Recent QUIC Changes. (Closed)

Created:
5 years, 10 months ago by ramant (doing other things)
Modified:
5 years, 10 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, alyssar, Ian Swett, rjshade, Jana
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Land Recent QUIC Changes. Change the initial maximum packet size for a QUIC server to 1000 bytes instead of 1350 bytes. Protected by FLAGS_quic_small_default_packet_size which is enabled by default. When the server receives the CHLO from the client, if the CHLO packet is larger, the server will increase its max packet length to match. Merge internal change: 86310847 https://codereview.chromium.org/916143004/ Adding DCHECKS in the crypto stream constructors to make sure is_server is set correctly, and fixing up tests accordingly. Merge internal change: 86300482 https://codereview.chromium.org/929033003/ Enable QUIC's pacing by default on all QUIC connections by setting FLAGS_quic_enable_pacing to true by default. Merge internal change: 86286914 https://codereview.chromium.org/933653003/ Fully qualify std::* names being exported internally by using declarations in third_party/stl/*. These using declarations are a historical artifact and they hinder portability and toolchain changes. Merge internal change: 86267997 https://codereview.chromium.org/925423004/ Adding an option to the quic client to not respect GOAWAYS. Didn't make this change in Chromium's QuicClientSession. Merge internal change: 86198166 https://codereview.chromium.org/930983002/ Deprecating FLAGS_quic_ack_notifier_informed_on_serialized. Merge internal change: 86177949 https://codereview.chromium.org/927173002/ Change QuicFramer so it accepts a QuicDataWriter rather than allocating one. Saves a full packet allocation by putting it on the stack. Merge internal change: 86104715 https://codereview.chromium.org/921883003/ Deprecate FLAGS_quic_use_std_cbrt. Merge internal change: 86087014 https://codereview.chromium.org/928163004/ R=rch@chromium.org Committed: https://crrev.com/16a2077e04314ebc536e28b689e8fb07bb2c6276 Cr-Commit-Position: refs/heads/master@{#316616}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -351 lines) Patch
M net/net.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
D net/quic/congestion_control/cube_root.h View 1 chunk +0 lines, -24 lines 0 comments Download
D net/quic/congestion_control/cube_root.cc View 1 chunk +0 lines, -86 lines 0 comments Download
D net/quic/congestion_control/cube_root_test.cc View 1 chunk +0 lines, -47 lines 0 comments Download
M net/quic/congestion_control/cubic.cc View 2 chunks +3 lines, -12 lines 0 comments Download
M net/quic/congestion_control/send_algorithm_simulator.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_test.cc View 4 chunks +3 lines, -5 lines 0 comments Download
M net/quic/crypto/crypto_framer.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M net/quic/crypto/quic_crypto_client_config.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config_test.cc View 2 chunks +1 line, -2 lines 0 comments Download
M net/quic/crypto/strike_register.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M net/quic/crypto/strike_register_test.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M net/quic/quic_connection.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M net/quic/quic_connection_test.cc View 1 chunk +58 lines, -0 lines 0 comments Download
M net/quic/quic_crypto_client_stream.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/quic/quic_crypto_client_stream_test.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M net/quic/quic_crypto_server_stream.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/quic/quic_crypto_server_stream_test.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M net/quic/quic_data_writer.h View 1 chunk +6 lines, -6 lines 0 comments Download
M net/quic/quic_data_writer.cc View 1 chunk +4 lines, -11 lines 0 comments Download
M net/quic/quic_data_writer_test.cc View 4 chunks +17 lines, -16 lines 0 comments Download
M net/quic/quic_dispatcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_flags.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/quic_flags.cc View 3 chunks +4 lines, -8 lines 0 comments Download
M net/quic/quic_framer.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_framer.cc View 12 chunks +28 lines, -31 lines 0 comments Download
M net/quic/quic_framer_test.cc View 5 chunks +10 lines, -7 lines 0 comments Download
M net/quic/quic_packet_creator.cc View 3 chunks +16 lines, -4 lines 0 comments Download
M net/quic/quic_protocol.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_received_packet_manager.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M net/quic/quic_received_packet_manager_test.cc View 3 chunks +12 lines, -13 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 4 chunks +3 lines, -9 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M net/quic/quic_stream_sequencer.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M net/quic/quic_stream_sequencer_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_time_wait_list_manager.cc View 2 chunks +1 line, -2 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +6 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 2 chunks +17 lines, -1 line 0 comments Download
M net/tools/quic/end_to_end_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_client_session.h View 2 chunks +8 lines, -0 lines 0 comments Download
M net/tools/quic/quic_client_session.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ramant (doing other things)
5 years, 10 months ago (2015-02-16 22:07:12 UTC) #1
Ryan Hamilton
lgtm
5 years, 10 months ago (2015-02-17 02:30:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/932723002/1
5 years, 10 months ago (2015-02-17 18:30:39 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 18:58:56 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 18:59:44 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/16a2077e04314ebc536e28b689e8fb07bb2c6276
Cr-Commit-Position: refs/heads/master@{#316616}

Powered by Google App Engine
This is Rietveld 408576698