Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Unified Diff: src/assembler-ia32.cc

Issue 9327: Remove duplicated code, the two emit_operand were basically identical. (Closed)
Patch Set: Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/assembler-ia32.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/assembler-ia32.cc
diff --git a/src/assembler-ia32.cc b/src/assembler-ia32.cc
index fbe63de67a1401010b59f40d657f740264c83a83..610542b596e7f6fa26b7e48bd1c353ea076172bd 100644
--- a/src/assembler-ia32.cc
+++ b/src/assembler-ia32.cc
@@ -781,7 +781,7 @@ void Assembler::and_(const Operand& dst, Register src) {
EnsureSpace ensure_space(this);
last_pc_ = pc_;
EMIT(0x21);
- emit_operand(dst, src);
+ emit_operand(src, dst);
}
@@ -949,7 +949,7 @@ void Assembler::or_(const Operand& dst, Register src) {
EnsureSpace ensure_space(this);
last_pc_ = pc_;
EMIT(0x09);
- emit_operand(dst, src);
+ emit_operand(src, dst);
}
@@ -1077,7 +1077,7 @@ void Assembler::sub(const Operand& dst, Register src) {
EnsureSpace ensure_space(this);
last_pc_ = pc_;
EMIT(0x29);
- emit_operand(dst, src);
+ emit_operand(src, dst);
}
@@ -2017,18 +2017,6 @@ void Assembler::emit_operand(Register reg, const Operand& adr) {
}
-void Assembler::emit_operand(const Operand& adr, Register reg) {
- adr.set_reg(reg);
- memmove(pc_, adr.buf_, adr.len_);
- pc_ += adr.len_;
- if (adr.len_ >= sizeof(int32_t) && adr.rmode_ != RelocInfo::NONE) {
- pc_ -= sizeof(int32_t); // pc_ must be *at* disp32
- RecordRelocInfo(adr.rmode_);
- pc_ += sizeof(int32_t);
- }
-}
-
-
void Assembler::emit_farith(int b1, int b2, int i) {
ASSERT(is_uint8(b1) && is_uint8(b2)); // wrong opcode
ASSERT(0 <= i && i < 8); // illegal stack offset
« no previous file with comments | « src/assembler-ia32.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698