Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: src/assembler-ia32.h

Issue 9327: Remove duplicated code, the two emit_operand were basically identical. (Closed)
Patch Set: Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/assembler-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 739 matching lines...) Expand 10 before | Expand all | Expand 10 after
750 // instruction generation 750 // instruction generation
751 void emit_arith_b(int op1, int op2, Register dst, int imm8); 751 void emit_arith_b(int op1, int op2, Register dst, int imm8);
752 752
753 // Emit a basic arithmetic instruction (i.e. first byte of the family is 0x81) 753 // Emit a basic arithmetic instruction (i.e. first byte of the family is 0x81)
754 // with a given destination expression and an immediate operand. It attempts 754 // with a given destination expression and an immediate operand. It attempts
755 // to use the shortest encoding possible. 755 // to use the shortest encoding possible.
756 // sel specifies the /n in the modrm byte (see the Intel PRM). 756 // sel specifies the /n in the modrm byte (see the Intel PRM).
757 void emit_arith(int sel, Operand dst, const Immediate& x); 757 void emit_arith(int sel, Operand dst, const Immediate& x);
758 758
759 void emit_operand(Register reg, const Operand& adr); 759 void emit_operand(Register reg, const Operand& adr);
760 void emit_operand(const Operand& adr, Register reg);
761 760
762 void emit_farith(int b1, int b2, int i); 761 void emit_farith(int b1, int b2, int i);
763 762
764 // labels 763 // labels
765 void print(Label* L); 764 void print(Label* L);
766 void bind_to(Label* L, int pos); 765 void bind_to(Label* L, int pos);
767 void link_to(Label* L, Label* appendix); 766 void link_to(Label* L, Label* appendix);
768 767
769 // displacements 768 // displacements
770 inline Displacement disp_at(Label* L); 769 inline Displacement disp_at(Label* L);
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
802 private: 801 private:
803 Assembler* assembler_; 802 Assembler* assembler_;
804 #ifdef DEBUG 803 #ifdef DEBUG
805 int space_before_; 804 int space_before_;
806 #endif 805 #endif
807 }; 806 };
808 807
809 } } // namespace v8::internal 808 } } // namespace v8::internal
810 809
811 #endif // V8_ASSEMBLER_IA32_H_ 810 #endif // V8_ASSEMBLER_IA32_H_
OLDNEW
« no previous file with comments | « no previous file | src/assembler-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698