Issue 932693003: Revert of Remove handle wrappers from basic elements accessors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 932693003: Revert of Remove handle wrappers from basic elements accessors (Closed)

Created:
5 years, 10 months ago by Toon Verwaest

Modified:
5 years, 10 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert of Remove handle wrappers from basic elements accessors (patchset #2 id:20001 of https://codereview.chromium.org/934173004/) Reason for revert: Breakage Original issue's description: > Remove handle wrappers from basic elements accessors > > BUG= > R=yangguo@chromium.org > > Committed: https://crrev.com/40b7c513c696f405af0ae3e74e844d3c341bc3f2 > Cr-Commit-Position: refs/heads/master@{#26736} TBR=yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/cca6ffff7e1db2581f6ef49fda70dc7e0759d2ec Cr-Commit-Position: refs/heads/master@{#26737}

Created: 5 years, 10 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+95 lines, -71 lines)			Patch
M	src/builtins.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/elements.h	View	4 chunks	+19 lines, -12 lines	0 comments	Download
M	src/elements.cc	View	20 chunks	+68 lines, -51 lines	0 comments	Download
M	src/objects.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/runtime/runtime-array.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

Toon Verwaest

Created Revert of Remove handle wrappers from basic elements accessors

5 years, 10 months ago (2015-02-19 09:04:07 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/932693003/1

5 years, 10 months ago (2015-02-19 09:04:39 UTC) #2

commit-bot: I haz the power

5 years, 10 months ago (2015-02-19 09:05:11 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/cca6ffff7e1db2581f6ef49fda70dc7e0759d2ec
Cr-Commit-Position: refs/heads/master@{#26737}