Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 932673002: Do not force Xcode clang when targetting arm64 (Closed)

Created:
5 years, 10 months ago by sdefresne
Modified:
5 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not force Xcode clang when targetting arm64 ToT clang now supports building for arm64 so remove the exception forcing using Xcode clang when targeting arm64 (or fat binaries) on iOS. BUG=341453 Committed: https://crrev.com/d4eb6e6969630f51fb64478e1f863591220d292c Cr-Commit-Position: refs/heads/master@{#316549}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M build/common.gypi View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sdefresne
I can now successfully build 64-bit binaries for iOS using ToT clang, so I think ...
5 years, 10 months ago (2015-02-16 18:21:04 UTC) #2
Nico
On 2015/02/16 18:21:04, sdefresne wrote: > I can now successfully build 64-bit binaries for iOS ...
5 years, 10 months ago (2015-02-16 20:26:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/932673002/1
5 years, 10 months ago (2015-02-17 09:52:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 09:55:46 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 09:56:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d4eb6e6969630f51fb64478e1f863591220d292c
Cr-Commit-Position: refs/heads/master@{#316549}

Powered by Google App Engine
This is Rietveld 408576698