Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Unified Diff: content/browser/appcache/appcache_response.h

Issue 932643002: Introduce AppCacheResponseMetadataWriter to support metadata caching. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: incorporated michaeln's comment Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/appcache/appcache_response.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/appcache/appcache_response.h
diff --git a/content/browser/appcache/appcache_response.h b/content/browser/appcache/appcache_response.h
index 4b7a32c6767f7fffc35baeb2bb31eded6e314538..8d6c79060bdcf2eb76ac5c4870d90fcdc36e089d 100644
--- a/content/browser/appcache/appcache_response.h
+++ b/content/browser/appcache/appcache_response.h
@@ -106,12 +106,14 @@ class CONTENT_EXPORT AppCacheResponseIO {
AppCacheDiskCacheInterface* disk_cache);
virtual void OnIOComplete(int result) = 0;
+ virtual void OnOpenEntryComplete() {}
bool IsIOPending() { return !callback_.is_null(); }
void ScheduleIOCompletionCallback(int result);
void InvokeUserCompletionCallback(int result);
void ReadRaw(int index, int offset, net::IOBuffer* buf, int buf_len);
void WriteRaw(int index, int offset, net::IOBuffer* buf, int buf_len);
+ void OpenEntryIfNeeded();
const int64 response_id_;
const int64 group_id_;
@@ -121,10 +123,12 @@ class CONTENT_EXPORT AppCacheResponseIO {
scoped_refptr<net::IOBuffer> buffer_;
int buffer_len_;
net::CompletionCallback callback_;
+ net::CompletionCallback open_callback_;
base::WeakPtrFactory<AppCacheResponseIO> weak_factory_;
private:
void OnRawIOComplete(int result);
+ void OpenEntryCallback(AppCacheDiskCacheInterface::Entry** entry, int rv);
};
// Reads existing response data from storage. If the object is deleted
@@ -178,15 +182,14 @@ class CONTENT_EXPORT AppCacheResponseReader
AppCacheDiskCacheInterface* disk_cache);
void OnIOComplete(int result) override;
+ void OnOpenEntryComplete() override;
void ContinueReadInfo();
void ContinueReadData();
- void OpenEntryIfNeededAndContinue();
- void OnOpenEntryComplete(AppCacheDiskCacheInterface::Entry** entry, int rv);
int range_offset_;
int range_length_;
int read_position_;
- net::CompletionCallback open_callback_;
+ int reading_metadata_size_;
base::WeakPtrFactory<AppCacheResponseReader> weak_factory_;
};
@@ -257,6 +260,47 @@ class CONTENT_EXPORT AppCacheResponseWriter
base::WeakPtrFactory<AppCacheResponseWriter> weak_factory_;
};
+// Writes metadata of the existing response to storage. If the object is deleted
+// and there is a write in progress, the implementation will return
+// immediately but will take care of any side effect of cancelling the
+// operation. In other words, instances are safe to delete at will.
+class CONTENT_EXPORT AppCacheResponseMetadataWriter
+ : public AppCacheResponseIO {
+ public:
+ ~AppCacheResponseMetadataWriter() override;
+
+ // Writes metadata to storage. Always returns the result of the write
+ // asynchronously through the 'callback'. Returns the number of bytes written
+ // or a net:: error code. Guaranteed to not perform partial writes.
+ // The writer acquires a reference to the provided 'buf' until completion at
+ // which time the callback is invoked with either a negative error code or
+ // the number of bytes written. The 'callback' is a required parameter.
+ // The contents of 'buf' are not modified.
+ // Should only be called where there is no WriteMetadata operation in
+ // progress.
+ void WriteMetadata(net::IOBuffer* buf,
+ int buf_len,
+ const net::CompletionCallback& callback);
+
+ // Returns true if there is a write pending.
+ bool IsWritePending() { return IsIOPending(); }
+
+ protected:
+ friend class AppCacheStorageImpl;
+ friend class content::MockAppCacheStorage;
+ // Should only be constructed by the storage class and derivatives.
+ AppCacheResponseMetadataWriter(int64 response_id,
+ int64 group_id,
+ AppCacheDiskCacheInterface* disk_cache);
+
+ private:
+ void OnIOComplete(int result) override;
+ void OnOpenEntryComplete() override;
+
+ int write_amount_;
+ base::WeakPtrFactory<AppCacheResponseMetadataWriter> weak_factory_;
+};
+
} // namespace content
#endif // CONTENT_BROWSER_APPCACHE_APPCACHE_RESPONSE_H_
« no previous file with comments | « no previous file | content/browser/appcache/appcache_response.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698