Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 932633002: Call NodeFilter.acceptNode() with correct this value (Closed)

Created:
5 years, 10 months ago by Jens Widell
Modified:
5 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Call NodeFilter.acceptNode() with correct this value Per WebIDL, a callback interface's operation should be called with object that implements the interface as this, unless the provided object itself is used as the function to call, in which case it should be called with this=undefined (by default, allowing for overridden by the algorithm that makes the call.) The code calling NodeFilter.acceptNode() always used the context's global object as this. Note that when this=undefined and the function called is not compiled in strict mode, the actual this value seen by the function will still be the global object. BUG=419548 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190299

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -11 lines) Patch
M LayoutTests/fast/dom/TreeWalker/acceptNode-filter-expected.txt View 1 chunk +13 lines, -6 lines 0 comments Download
M LayoutTests/fast/dom/TreeWalker/script-tests/acceptNode-filter.js View 2 chunks +19 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/V8NodeFilterCondition.cpp View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jens Widell
PTAL The new behavior (which in the common case is the same as the old ...
5 years, 10 months ago (2015-02-16 16:14:45 UTC) #2
haraken
LGTM
5 years, 10 months ago (2015-02-16 23:25:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/932633002/1
5 years, 10 months ago (2015-02-17 06:14:43 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 08:44:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190299

Powered by Google App Engine
This is Rietveld 408576698