Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 932583002: Remove prototype key from the prototype transitions since its also embedded in the target map. (Closed)

Created:
5 years, 10 months ago by Toon Verwaest
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove prototype key from the prototype transitions since its also embedded in the target map. BUG= Committed: https://crrev.com/a1f7b01ccf9d4771c58d2816e3c649946da14ab0 Cr-Commit-Position: refs/heads/master@{#26662}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -52 lines) Patch
M src/heap/mark-compact.cc View 2 chunks +6 lines, -17 lines 0 comments Download
M src/objects.h View 1 chunk +2 lines, -7 lines 0 comments Download
M src/objects.cc View 1 2 3 3 chunks +12 lines, -23 lines 1 comment Download
M test/cctest/test-heap.cc View 1 2 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Toon Verwaest
PTAL
5 years, 10 months ago (2015-02-16 12:05:35 UTC) #2
Igor Sheludko
lgtm
5 years, 10 months ago (2015-02-16 12:27:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/932583002/60001
5 years, 10 months ago (2015-02-16 12:47:46 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-16 13:09:59 UTC) #7
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/a1f7b01ccf9d4771c58d2816e3c649946da14ab0 Cr-Commit-Position: refs/heads/master@{#26662}
5 years, 10 months ago (2015-02-16 13:10:14 UTC) #8
Hannes Payer (out of office)
5 years, 10 months ago (2015-02-16 13:37:20 UTC) #9
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/932583002/diff/60001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/932583002/diff/60001/src/objects.cc#newcode11837
src/objects.cc:11837: int new_capacity = Min(kMaxCachedPrototypeTransitions,
transitions * 2);
We could have used a constant there for the growing factor.

Powered by Google App Engine
This is Rietveld 408576698