Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1685)

Unified Diff: Source/web/WebDevToolsAgentImpl.cpp

Issue 932523003: DevTools: [Blink-side] Fix debugger command order (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebDevToolsAgentImpl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebDevToolsAgentImpl.cpp
diff --git a/Source/web/WebDevToolsAgentImpl.cpp b/Source/web/WebDevToolsAgentImpl.cpp
index d711f645e1008e0f7f2857c37434495d4bfe8aca..5db596ed8c7fe3957d7f9a90442f12ea12a4f2ba 100644
--- a/Source/web/WebDevToolsAgentImpl.cpp
+++ b/Source/web/WebDevToolsAgentImpl.cpp
@@ -190,8 +190,12 @@ public:
virtual ~DebuggerTask() { }
virtual void run()
{
- if (WebDevToolsAgent* webagent = m_descriptor->agent())
- webagent->dispatchOnInspectorBackend(m_descriptor->message());
+ WebDevToolsAgent* webagent = m_descriptor->agent();
+ if (!webagent)
+ return;
+
+ WebDevToolsAgentImpl* agentImpl = static_cast<WebDevToolsAgentImpl*>(webagent);
+ agentImpl->inspectorController()->dispatchMessageFromFrontend(m_descriptor->message());
pfeldman 2015/02/17 09:23:16 check for m_attached is missing.
yurys 2015/02/17 09:44:00 It might make sense to extract if (m_attached)
sergeyv 2015/02/17 11:32:59 Done.
}
private:
@@ -444,7 +448,10 @@ void WebDevToolsAgentImpl::dispatchOnInspectorBackend(const WebString& message)
{
if (!m_attached)
return;
- inspectorController()->dispatchMessageFromFrontend(message);
+ if (WebDevToolsAgent::shouldInterruptForMessage(message))
+ PageScriptDebugServer::shared().runPendingTasks();
+ else
+ inspectorController()->dispatchMessageFromFrontend(message);
}
void WebDevToolsAgentImpl::inspectElementAt(const WebPoint& point)
« no previous file with comments | « Source/web/WebDevToolsAgentImpl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698