Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: Source/web/WebDevToolsAgentImpl.cpp

Issue 932523003: DevTools: [Blink-side] Fix debugger command order (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebDevToolsAgentImpl.h ('k') | public/web/WebDevToolsAgent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebDevToolsAgentImpl.cpp
diff --git a/Source/web/WebDevToolsAgentImpl.cpp b/Source/web/WebDevToolsAgentImpl.cpp
index d711f645e1008e0f7f2857c37434495d4bfe8aca..17f99dadcb4440cc3dbb4a9e44d0b250d3f2894a 100644
--- a/Source/web/WebDevToolsAgentImpl.cpp
+++ b/Source/web/WebDevToolsAgentImpl.cpp
@@ -191,7 +191,7 @@ public:
virtual void run()
{
if (WebDevToolsAgent* webagent = m_descriptor->agent())
- webagent->dispatchOnInspectorBackend(m_descriptor->message());
+ webagent->dispatchOnInspectorBackend(m_descriptor->message(), true);
}
private:
@@ -440,11 +440,14 @@ void WebDevToolsAgentImpl::dispatchMouseEvent(const PlatformMouseEvent& event)
m_generatingEvent = false;
}
-void WebDevToolsAgentImpl::dispatchOnInspectorBackend(const WebString& message)
+void WebDevToolsAgentImpl::dispatchOnInspectorBackend(const WebString& message, bool ignoreInterrupt)
{
if (!m_attached)
return;
- inspectorController()->dispatchMessageFromFrontend(message);
+ if (ignoreInterrupt || !WebDevToolsAgent::shouldInterruptForMessage(message))
yurys 2015/02/16 16:33:07 You don't need this parameter as before the chromi
yurys 2015/02/16 16:56:15 To clarify this after offline discussion. We can m
sergeyv 2015/02/16 17:30:13 Done.
+ inspectorController()->dispatchMessageFromFrontend(message);
+ else
+ PageScriptDebugServer::shared().runPendingTasks();
}
void WebDevToolsAgentImpl::inspectElementAt(const WebPoint& point)
« no previous file with comments | « Source/web/WebDevToolsAgentImpl.h ('k') | public/web/WebDevToolsAgent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698