Move more tests to SkipByDesign

pkg/pkg.status

 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 # Don't run any test-like files that show up in packages directories. It
 # shouldn't be necessary to run "pub install" in these packages, but if you do
 # it shouldn't break the tests.
 */packages/*/*: Skip
 */*/packages/*/*: Skip
 */*/*/packages/*/*: Skip
@@ skipping 130 matching lines @@
 
 [ $compiler == dart2js && $csp ]
 # This test cannot run under CSP because it is injecting a JavaScript polyfill
 mutation_observer: Skip
 
 [ $compiler == dart2js && $browser ]
 crypto/test/sha256_test: Slow, Pass
 crypto/test/sha1_test: Slow, Pass
 
 [ $browser ]
+*/test/analyzer_test: SkipByDesign # No need to run analysis tests on browser bots

[Bill Hesse, 2015/02/23 08:53:25]

Why is this?  Could there be a better explanation?  Is it not possible?

[kevmoo, 2015/02/23 21:30:17]

I'm not sure, honestly. I'm just running with what's already here.

This is good to go through when we do the linter

 analysis_server/test/*: SkipByDesign # Uses dart:io.
 analysis_server/tool/spec/check_all_test: SkipByDesign # Uses dart:io.
+analyzer/test/*: SkipByDesign # Uses dart:io.
 analyzer2dart/*: SkipByDesign # Uses dart:io.
-analyzer/test/*: SkipByDesign # Uses dart:io.
+docgen/test/*: SkipByDesign  # Uses dart:io

[Bill Hesse, 2015/02/23 08:53:25]

I know these are slow, but it seems like there should be a way to make these run
on the browser, using HTML5 features.  It would be a good stress test.  Maybe we
should file an issue.

[Bill Hesse, 2015/02/23 08:53:25]

Add . to the end to be consistent.

[kevmoo, 2015/02/23 21:30:17]

Done.

[kevmoo, 2015/02/23 21:30:17]

docgen is actually going away soonish – well, replaced by a project on github

 http_server/test/*: Fail, OK # Uses dart:io.
 observe/test/transformer_test: Fail, OK # Uses dart:io.
-observe/test/unique_message_test: Skip # Intended only as a vm test.
+observe/test/unique_message_test: SkipByDesign  # Uses dart:io
 stub_core_library/test/*: Fail, OK # Uses dart:io.
 third_party/angular_tests/browser_test/core_dom/cookies: Fail # Issue 16337
 third_party/angular_tests/vm_test: SkipByDesign # Uses dart:io
-
-*/test/analyzer_test: Skip  # No need to run analysis tests on browser bots
-
-# Skip tests on the browser if the test depends on dart:io
-third_party/html5lib/test/parser_test: Skip
-third_party/html5lib/test/tokenizer_test: Skip
-third_party/html5lib/test/selectors/*: Skip
+third_party/html5lib/test/parser_test: SkipByDesign # Uses dart:io.
+third_party/html5lib/test/selectors/*: SkipByDesign # Uses dart:io.
+third_party/html5lib/test/tokenizer_test: SkipByDesign # Uses dart:io.
 
 [ $arch == simarm64 ]
 # Timeout. These are not unit tests. They do not run efficiently on our
 # simulator.
 *: Skip
 
 [ $runtime == vm ]
 # Skip tests on the VM if the package depends on dart:html
 mutation_observer: Skip
 third_party/html5lib/test/browser/browser_test: Skip
 
-[ $browser ]
-docgen/test/*: Skip  # Uses dart:io
-
 [ $compiler == dartanalyzer || $compiler == dart2analyzer ]
 third_party/angular_tests/vm_test: StaticWarning # Uses removed APIs. See issue 18733.
 analyzer2dart/test/driver_test: StaticWarning # Issue 22418
 analyzer2dart/test/sexpr_test: StaticWarning # Issue 22418
 analyzer2dart/test/tree_shaker_test: StaticWarning # Issue 22418
 analyzer2dart/test/end2end_test: StaticWarning # Issue 22418
 docgen/test/multi_library_test: StaticWarning # Issue 22475
 docgen/test/method_param_test: StaticWarning # Issue 22475
 docgen/test/async_await_test: StaticWarning # Issue 22475
 docgen/test/typedef_test: StaticWarning # Issue 22475
 docgen/test/metadata_test: StaticWarning # Issue 22475
 docgen/test/native_extensions_test: StaticWarning # Issue 22475
 docgen/test/generate_json_test: StaticWarning # Issue 22475
 docgen/test/only_lib_content_in_pkg_test: StaticWarning # Issue 22475
 docgen/test/constant_argument_test: StaticWarning # Issue 22475
 docgen/test/inherited_comments_test: StaticWarning # Issue 22475
 docgen/test/single_library_test: StaticWarning # Issue 22475
 
 [ $runtime == safari || $runtime == safarimobilesim || $runtime == chrome || $runtime == ff || $ie ]
 # Various issues due to limited browser testing in Angular.
 third_party/angular_tests/*: Skip
 
 [ $unchecked ]
-third_party/angular_tests/browser_test/angular: Skip # Requires checked mode.
-third_party/angular_tests/browser_test/core/scope: Skip # Requires checked mode.
-third_party/angular_tests/browser_test/core/zone: Skip # Requires checked mode.
+third_party/angular_tests/browser_test/angular: SkipByDesign # Requires checked mode.
+third_party/angular_tests/browser_test/core/scope: SkipByDesign # Requires checked mode.
+third_party/angular_tests/browser_test/core/zone: SkipByDesign # Requires checked mode.
 third_party/angular_tests/browser_test/directive/ng_repeat: Skip # Issue 17152
 third_party/angular_tests/browser_test/change_detection/dirty_checking_change_detector: Skip # Issue 17152
 
 [ $use_repository_packages ]
 analyzer/test/*: PubGetError