[android] Hide <select> dropdown on outside tap.

[android] Hide <select> dropdown on outside tap.

Outside tap should hide <select> dropdowns, but not dropdowns associated
with input fields. Tapping on an input field should not hide the
associated autofill or password generation popup.

BUG=430543
Committed: https://crrev.com/2d616c68a8fd923e378b6473302c1406f19aa8cb
Cr-Commit-Position: refs/heads/master@{#316641}

[please use gerrit instead, 2015-02-17 19:10:08]

rouslan@chromium.org changed reviewers:
+ jdduke@chromium.org

[please use gerrit instead, 2015-02-17 19:10:09]

Jared, PTAL.

This patch makes sure that <select> dropdown is hidden on page scroll.

[aurimas (slooooooooow), 2015-02-17 19:11:03]

aurimas@chromium.org changed reviewers:
+ aurimas@chromium.org

[aurimas (slooooooooow), 2015-02-17 19:11:04]

lgtm

[jdduke (slow), 2015-02-17 19:16:27]

On 2015/02/17 19:11:04, aurimas wrote:
> lgtm

Doesn't this also affect desktop/CrOS?

[aurimas (slooooooooow), 2015-02-17 19:16:49]

On 2015/02/17 at 19:16:27, jdduke wrote:
> On 2015/02/17 19:11:04, aurimas wrote:
> > lgtm
> 
> Doesn't this also affect desktop/CrOS?

This is Android only.

[jdduke (slow), 2015-02-17 19:19:33]

On 2015/02/17 19:16:49, aurimas wrote:
> On 2015/02/17 at 19:16:27, jdduke wrote:
> > On 2015/02/17 19:11:04, aurimas wrote:
> > > lgtm
> > 
> > Doesn't this also affect desktop/CrOS?
> 
> This is Android only.

I meant doesn't the underlying issue affect desktop/CrOS. If I scroll my Pixel
with a <select> dropdown open, it stays visible but becomes detached from the
underlying content, just as on Android. So I'm wondering if there's a potential
unified fix, or if this needs to be fixed per platform.

[jdduke (slow), 2015-02-17 19:20:53]

jdduke@chromium.org changed reviewers:
+ keishi@chromium.org

[jdduke (slow), 2015-02-17 19:20:53]

+keishi: Are there any immediate plans to change how <select> dropdowns are
rendered on Android (for tablets)? This solution seems reasonable, just want to
make sure we're addressing this issue everywhere.

[aurimas (slooooooooow), 2015-02-17 19:20:54]

On 2015/02/17 at 19:19:33, jdduke wrote:
> On 2015/02/17 19:16:49, aurimas wrote:
> > On 2015/02/17 at 19:16:27, jdduke wrote:
> > > On 2015/02/17 19:11:04, aurimas wrote:
> > > > lgtm
> > > 
> > > Doesn't this also affect desktop/CrOS?
> > 
> > This is Android only.
> 
> I meant doesn't the underlying issue affect desktop/CrOS. If I scroll my Pixel
with a <select> dropdown open, it stays visible but becomes detached from the
underlying content, just as on Android. So I'm wondering if there's a potential
unified fix, or if this needs to be fixed per platform.

I *think* only android shares the same popup implementation between autofill and
select.

[jdduke (slow), 2015-02-17 19:25:07]

On 2015/02/17 19:20:54, aurimas wrote:
> On 2015/02/17 at 19:19:33, jdduke wrote:
> > On 2015/02/17 19:16:49, aurimas wrote:
> > > On 2015/02/17 at 19:16:27, jdduke wrote:
> > > > On 2015/02/17 19:11:04, aurimas wrote:
> > > > > lgtm
> > > > 
> > > > Doesn't this also affect desktop/CrOS?
> > > 
> > > This is Android only.
> > 
> > I meant doesn't the underlying issue affect desktop/CrOS. If I scroll my
Pixel
> with a <select> dropdown open, it stays visible but becomes detached from the
> underlying content, just as on Android. So I'm wondering if there's a
potential
> unified fix, or if this needs to be fixed per platform.
> 
> I *think* only android shares the same popup implementation between autofill
and
> select.

Right, I'm just saying, this solution fixes the visual detaching of the dropdown
from the content on Android, but not for other platforms, so I want to make sure
that gets addressed, or is being addressed.

[please use gerrit instead, 2015-02-17 19:49:29]

The Android <select> dropdown is implemented in:

https://code.google.com/p/chromium/codesearch#chromium/src/content/public/and...

I'm fixing it because I'm on the autofill team, which caused the Android
regression. CroOS uses Views.  I'm not aware of any bug for <select> dropdown on
Views. If there's a problem there, please file a separate bug...

[jdduke (slow), 2015-02-17 19:49:59]

On 2015/02/17 19:49:29, Rouslan Solomakhin wrote:
> The Android <select> dropdown is implemented in:
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/public/and...
> 
> I'm fixing it because I'm on the autofill team, which caused the Android
> regression. CroOS uses Views.  I'm not aware of any bug for <select> dropdown
on
> Views. If there's a problem there, please file a separate bug...

OK, lgtm.

[please use gerrit instead, 2015-02-17 19:54:44]

The CQ bit was checked by rouslan@chromium.org

[commit-bot: I haz the power, 2015-02-17 19:55:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/932493003/1

[commit-bot: I haz the power, 2015-02-17 20:14:23]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-02-17 20:15:28]

Patchset 1 (id:??) landed as
https://crrev.com/2d616c68a8fd923e378b6473302c1406f19aa8cb
Cr-Commit-Position: refs/heads/master@{#316641}