Issue 932423002: Issue 17356. Apply selection returned from formatter to the SourceViewer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 932423002: Issue 17356. Apply selection returned from formatter to the SourceViewer. (Closed)

Created:
5 years, 10 months ago by scheglov

Modified:
5 years, 10 months ago

Reviewers:
danrubel

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

Issue 17356. Apply selection returned from formatter to the SourceViewer. There are some issues in dart_style with computing selection after formatting. See https://github.com/dart-lang/dart_style/issues/175 R=danrubel@google.com BUG= https://code.google.com/p/dart/issues/detail?id=17356 Committed: https://code.google.com/p/dart/source/detail?r=43918

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -30 lines)			Patch
	M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/formatter/DartFormatter.java	View		2 chunks	+26 lines, -23 lines	0 comments	Download
	M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/DartEditor.java	View		3 chunks	+19 lines, -7 lines	0 comments	Download

Total messages: 3 (0 generated)

scheglov

5 years, 10 months ago (2015-02-20 16:10:20 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 43918 (presubmit successful).