Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 932333004: [strong] Deprecate arguments (Closed)

Created:
5 years, 10 months ago by rossberg
Modified:
5 years, 10 months ago
Reviewers:
marja
CC:
v8-dev, arv (Not doing code reviews)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[strong] Deprecate arguments R=marja@chromium.org BUG= Committed: https://crrev.com/0ebd870f720c8f3175b89257dd42386f98b056f8 Cr-Commit-Position: refs/heads/master@{#26753}

Patch Set 1 #

Patch Set 2 : Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -22 lines) Patch
M src/ast-value-factory.h View 1 2 chunks +0 lines, -7 lines 0 comments Download
M src/messages.js View 1 chunk +1 line, -0 lines 0 comments Download
M src/parser.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/parser.cc View 1 chunk +11 lines, -2 lines 0 comments Download
M src/preparser.h View 5 chunks +23 lines, -13 lines 0 comments Download
A test/mjsunit/strong/arguments.js View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
rossberg
5 years, 10 months ago (2015-02-19 13:31:16 UTC) #1
marja
lgtm *except* pls remove the IsArguments from ast_value_factory.h, it's now dead code.
5 years, 10 months ago (2015-02-19 13:37:36 UTC) #2
marja
... actually, do all test_parsing tests run now? Aren't there any tests there which test ...
5 years, 10 months ago (2015-02-19 13:38:11 UTC) #3
rossberg
On 2015/02/19 13:37:36, marja wrote: > pls remove the IsArguments from ast_value_factory.h, it's now dead ...
5 years, 10 months ago (2015-02-19 14:19:40 UTC) #5
marja
> > ... actually, do all test_parsing tests run now? Aren't there any tests there ...
5 years, 10 months ago (2015-02-19 14:33:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/932333004/20001
5 years, 10 months ago (2015-02-19 14:37:37 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-19 14:58:38 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 14:58:52 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0ebd870f720c8f3175b89257dd42386f98b056f8
Cr-Commit-Position: refs/heads/master@{#26753}

Powered by Google App Engine
This is Rietveld 408576698