Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: media/audio/android/opensles_output.h

Issue 93233003: Mute audio when volume is zero on Android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/android/opensles_output.h
diff --git a/media/audio/android/opensles_output.h b/media/audio/android/opensles_output.h
index 7232d5da5f76210dee252f44946d141d075e19be..8e77d5e2550f4368ce5dfda0ea471c7ee70ef003 100644
--- a/media/audio/android/opensles_output.h
+++ b/media/audio/android/opensles_output.h
@@ -40,6 +40,8 @@ class OpenSLESOutputStream : public AudioOutputStream {
virtual void SetVolume(double volume) OVERRIDE;
virtual void GetVolume(double* volume) OVERRIDE;
+ void SetMute(bool muted);
henrika (OOO until Aug 14) 2013/12/03 11:02:28 Perhaps worth mentioning that muted=true does not
wjia(left Chromium) 2013/12/04 00:53:30 Done.
+
private:
bool CreatePlayer();
@@ -96,6 +98,12 @@ class OpenSLESOutputStream : public AudioOutputStream {
bool started_;
+ // Volume control coming from hardware. It overrides |volume_| when it's
+ // true. Otherwise, use |volume_| for scaling.
+ // This is needed because platform voice volume never goes to zero in
+ // COMMUNICATION mode on Android.
+ bool muted_;
+
// Volume level from 0 to 1.
float volume_;

Powered by Google App Engine
This is Rietveld 408576698