Use InterstitialPage through a delegate interface instead of deriving from it.

chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This test creates a fake safebrowsing service, where we can inject
 // malware and phishing urls.  It then uses a real browser to go to
 // these urls, and sends "goback" or "proceed" commands and verifies
 // they work.
 
 #include "base/bind.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/safe_browsing/malware_details.h"
 #include "chrome/browser/safe_browsing/safe_browsing_blocking_page.h"
 #include "chrome/browser/safe_browsing/safe_browsing_service.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "content/browser/renderer_host/resource_dispatcher_host.h"
+#include "content/browser/tab_contents/interstitial_page.h"
 #include "content/public/browser/navigation_controller.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_view.h"
 #include "content/test/test_browser_thread.h"
 
 using content::BrowserThread;
 using content::NavigationController;
 using content::WebContents;
 
 // A SafeBrowingService class that allows us to inject the malicious URLs.
@@ skipping 223 matching lines @@
   void AddURLResult(const GURL& url,
                     SafeBrowsingService::UrlCheckResult checkresult) {
     FakeSafeBrowsingService* service =
         static_cast<FakeSafeBrowsingService*>(
             g_browser_process->safe_browsing_service());
 
     ASSERT_TRUE(service);
     service->AddURLResult(url, checkresult);
   }
 
-  void SendCommand(const std::string& command) {
-    WebContents* contents =
-        browser()->GetSelectedTabContentsWrapper()->web_contents();
+  TestSafeBrowsingBlockingPage* GetSafeBrowsingBlockingPage() {
     // We use InterstitialPage::GetInterstitialPage(tab) instead of
     // tab->GetInterstitialPage() because the tab doesn't have a pointer
     // to its interstital page until it gets a command from the renderer
     // that it has indeed displayed it -- and this sometimes happens after
     // NavigateToURL returns.
-    SafeBrowsingBlockingPage* interstitial_page =
-        static_cast<SafeBrowsingBlockingPage*>(
-            InterstitialPage::GetInterstitialPage(contents));
-    ASSERT_TRUE(interstitial_page);
-    interstitial_page->CommandReceived(command);
+    WebContents* contents =
+        browser()->GetSelectedTabContentsWrapper()->web_contents();
+    return static_cast<TestSafeBrowsingBlockingPage*>(
+          contents->GetInterstitialPage()->GetDelegateForTesting());
+  }
+
+  void SendCommand(const std::string& command) {
+    GetSafeBrowsingBlockingPage()->CommandReceived(command);
   }
 
   void DontProceedThroughInterstitial() {
     WebContents* contents =
         browser()->GetSelectedTabContentsWrapper()->web_contents();
     InterstitialPage* interstitial_page = InterstitialPage::GetInterstitialPage(
         contents);
     ASSERT_TRUE(interstitial_page);
     interstitial_page->DontProceed();
   }
 
   void ProceedThroughInterstitial() {
     WebContents* contents =
         browser()->GetSelectedTabContentsWrapper()->web_contents();
     InterstitialPage* interstitial_page = InterstitialPage::GetInterstitialPage(
         contents);
     ASSERT_TRUE(interstitial_page);
     interstitial_page->Proceed();
   }
 
   void AssertNoInterstitial(bool wait_for_delete) {
     WebContents* contents =
         browser()->GetSelectedTabContentsWrapper()->web_contents();
 
     if (contents->ShowingInterstitialPage() && wait_for_delete) {
       // We'll get notified when the interstitial is deleted.
-      static_cast<TestSafeBrowsingBlockingPage*>(
-          contents->GetInterstitialPage())->set_wait_for_delete();
+      GetSafeBrowsingBlockingPage()->set_wait_for_delete();
       ui_test_utils::RunMessageLoop();
     }
 
     // Can't use InterstitialPage::GetInterstitialPage() because that
     // gets updated after the TestSafeBrowsingBlockingPage destructor
     ASSERT_FALSE(contents->ShowingInterstitialPage());
   }
 
   bool YesInterstitial() {
     WebContents* contents =
@@ skipping 265 matching lines @@
   SendCommand("\"proceed\"");  // Simulate the user clicking "back"
   AssertNoInterstitial(true);  // Assert the interstitial is gone
 
   EXPECT_EQ(
       url,
       browser()->GetSelectedTabContentsWrapper()->web_contents()->GetURL());
   AssertReportSent();
 }
 
 }  // namespace