Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 932283002: Port touch-demo.sky to Dart and make it work in SkyShell (Closed)

Created:
5 years, 10 months ago by abarth-chromium
Modified:
5 years, 10 months ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Port touch-demo.sky to Dart and make it work in SkyShell We still don't quite handle multitouch correctly, but single touches work now. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0c9335bca3f7ea2506ed0052edc430f3c4d448ec

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -46 lines) Patch
M sky/examples/touch-demo.sky View 2 chunks +13 lines, -16 lines 0 comments Download
A + sky/services/viewport/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
A sky/services/viewport/input_event.mojom View 1 chunk +43 lines, -0 lines 0 comments Download
A sky/services/viewport/viewport_observer.mojom View 1 chunk +12 lines, -0 lines 1 comment Download
M sky/shell/BUILD.gn View 3 chunks +4 lines, -0 lines 0 comments Download
M sky/shell/apk/src/org/domokit/sky/shell/PlatformView.java View 5 chunks +52 lines, -6 lines 0 comments Download
M sky/shell/platform_view.h View 1 chunk +3 lines, -0 lines 0 comments Download
M sky/shell/platform_view.cc View 3 chunks +14 lines, -13 lines 0 comments Download
M sky/shell/ui/engine.h View 4 chunks +10 lines, -1 line 0 comments Download
M sky/shell/ui/engine.cc View 4 chunks +22 lines, -4 lines 0 comments Download
A sky/shell/ui/input_event_converter.h View 1 chunk +21 lines, -0 lines 0 comments Download
A sky/shell/ui/input_event_converter.cc View 1 chunk +64 lines, -0 lines 0 comments Download
M sky/shell/ui_delegate.h View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
abarth-chromium
5 years, 10 months ago (2015-02-19 00:43:06 UTC) #1
eseidel
lgtm
5 years, 10 months ago (2015-02-19 00:50:20 UTC) #2
eseidel
https://codereview.chromium.org/932283002/diff/1/sky/services/viewport/viewport_observer.mojom File sky/services/viewport/viewport_observer.mojom (right): https://codereview.chromium.org/932283002/diff/1/sky/services/viewport/viewport_observer.mojom#newcode10 sky/services/viewport/viewport_observer.mojom:10: OnViewportMetricsChanged(int32 width, int32 height, float device_pixel_ratio); unsigned?
5 years, 10 months ago (2015-02-19 00:50:34 UTC) #3
abarth-chromium
5 years, 10 months ago (2015-02-19 00:57:36 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
0c9335bca3f7ea2506ed0052edc430f3c4d448ec (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698