Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 932263002: [App banners] Stop passing JNI barrier to get icon size (Closed)

Created:
5 years, 10 months ago by gone
Modified:
5 years, 10 months ago
Reviewers:
Ted C
CC:
chromium-reviews, David Trainor- moved to gerrit, avayvod+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[App banners] Stop passing JNI barrier to get icon size Also deletes a bunch of comments that no longer apply and need to be rewritten. BUG=457413 Committed: https://crrev.com/8d2211bf7e80df7d4fdd1d038e9424bd15268aa2 Cr-Commit-Position: refs/heads/master@{#316960}

Patch Set 1 #

Patch Set 2 : Rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -63 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/Tab.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java View 1 4 chunks +6 lines, -12 lines 0 comments Download
M chrome/browser/android/banners/app_banner_manager.h View 4 chunks +7 lines, -35 lines 0 comments Download
M chrome/browser/android/banners/app_banner_manager.cc View 1 4 chunks +8 lines, -15 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
gone
5 years, 10 months ago (2015-02-19 00:14:01 UTC) #2
Ted C
lgtm
5 years, 10 months ago (2015-02-19 00:19:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/932263002/1
5 years, 10 months ago (2015-02-19 00:22:35 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/11671)
5 years, 10 months ago (2015-02-19 01:06:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/932263002/1
5 years, 10 months ago (2015-02-19 01:07:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/932263002/20001
5 years, 10 months ago (2015-02-19 01:10:36 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-19 01:41:15 UTC) #14
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 01:41:58 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8d2211bf7e80df7d4fdd1d038e9424bd15268aa2
Cr-Commit-Position: refs/heads/master@{#316960}

Powered by Google App Engine
This is Rietveld 408576698