Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 932183002: Revert of Revert of cc: Default threaded GPU rasterization to ON. (Closed)

Created:
5 years, 10 months ago by vmiura
Modified:
5 years, 10 months ago
Reviewers:
no sievers, Sami
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, aelias_OOO_until_Jul13, jdduke (slow), Vangelis Kokkevis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of cc: Default threaded GPU rasterization to ON. (patchset #1 id:1 of https://codereview.chromium.org/936803002/) Reason for revert: Known issue with this device. Workaround is incoming crrev.com/896303004/. Original issue's description: > Revert of cc: Default threaded GPU rasterization to ON. (patchset #1 id:1 of https://codereview.chromium.org/927463004/) > > Reason for revert: > Breaks compositor rendering on Nexus 6: crbug.com/459557 > > Original issue's description: > > cc: Default threaded GPU rasterization to ON. > > > > BUG=454500 > > > > Committed: https://crrev.com/96a23833e024783905297b60e7d86ca588ada45c > > Cr-Commit-Position: refs/heads/master@{#316665} > > TBR=sievers@chromium.org,vmiura@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=454500 > > Committed: https://crrev.com/2b0273be4aa28177d202942eadea5e8086f1ae79 > Cr-Commit-Position: refs/heads/master@{#316840} TBR=sievers@chromium.org,skyostil@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=454500 Committed: https://crrev.com/8a54728bf7062805ec3ebe7fcdc32f21b96d7a2c Cr-Commit-Position: refs/heads/master@{#316856}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M content/browser/gpu/compositor_util.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
vmiura
Created Revert of Revert of cc: Default threaded GPU rasterization to ON.
5 years, 10 months ago (2015-02-18 17:50:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/932183002/1
5 years, 10 months ago (2015-02-18 17:50:55 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-18 17:51:29 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8a54728bf7062805ec3ebe7fcdc32f21b96d7a2c Cr-Commit-Position: refs/heads/master@{#316856}
5 years, 10 months ago (2015-02-18 17:52:01 UTC) #5
Sami
On 2015/02/18 17:50:10, vmiura wrote: > Created Revert of Revert of cc: Default threaded GPU ...
5 years, 10 months ago (2015-02-18 17:52:28 UTC) #6
vmiura
5 years, 10 months ago (2015-02-18 19:19:55 UTC) #7
Message was sent while issue was closed.
On 2015/02/18 17:52:28, Sami wrote:
> On 2015/02/18 17:50:10, vmiura wrote:
> > Created Revert of Revert of cc: Default threaded GPU rasterization to ON.
> 
> Might want to let the fix land first :)

Yeah, sorry I want to this to stay on so we can find any other issues.

The Nexus 6 bug was reproduced before Threaded GPU as well, although this made
it appear more easily.  crbug.com/457027.

Powered by Google App Engine
This is Rietveld 408576698