Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Unified Diff: snapshot/minidump/minidump_string_reader.cc

Issue 932153003: Add ProcessSnapshotMinidump, the beginning of the minidump variant of the Snapshot family (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Address review feedback Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « snapshot/minidump/minidump_string_reader.h ('k') | snapshot/minidump/process_snapshot_minidump.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: snapshot/minidump/minidump_string_reader.cc
diff --git a/snapshot/minidump/minidump_string_reader.cc b/snapshot/minidump/minidump_string_reader.cc
new file mode 100644
index 0000000000000000000000000000000000000000..6ea36089f60c726e2ec8c7a62e7b00a12ca8b16b
--- /dev/null
+++ b/snapshot/minidump/minidump_string_reader.cc
@@ -0,0 +1,50 @@
+// Copyright 2015 The Crashpad Authors. All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "snapshot/minidump/minidump_string_reader.h"
+
+#include "base/logging.h"
+#include "minidump/minidump_extensions.h"
+
+namespace crashpad {
+namespace internal {
+
+bool ReadMinidumpUTF8String(FileReaderInterface* file_reader,
+ RVA rva,
+ std::string* string) {
+ if (rva == 0) {
+ string->clear();
+ return true;
+ }
+
+ if (!file_reader->SeekSet(rva)) {
+ return false;
+ }
+
+ uint32_t string_size;
+ if (!file_reader->ReadExactly(&string_size, sizeof(string_size))) {
+ return false;
+ }
+
+ std::string local_string(string_size, '\0');
+ if (!file_reader->ReadExactly(&local_string[0], string_size)) {
+ return false;
+ }
+
+ string->swap(local_string);
+ return true;
+}
+
+} // namespace internal
+} // namespace crashpad
« no previous file with comments | « snapshot/minidump/minidump_string_reader.h ('k') | snapshot/minidump/process_snapshot_minidump.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698