Add ProcessSnapshotMinidump, the beginning of the minidump variant of the Snapshot family

snapshot/minidump/minidump_simple_string_dictionary_reader.h

+// Copyright 2015 The Crashpad Authors. All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#ifndef CRASHPAD_SNAPSHOT_MINIDUMP_MINIDUMP_SIMPLE_STRING_DICTIONARY_READER_H_
+#define CRASHPAD_SNAPSHOT_MINIDUMP_MINIDUMP_SIMPLE_STRING_DICTIONARY_READER_H_
+
+#include <windows.h>
+#include <dbghelp.h>
+
+#include <map>
+#include <string>
+
+#include "util/file/file_reader.h"
+
+namespace crashpad {
+namespace internal {
+
+//! \brief Reads a MinidumpSimpleStringDictionary from a minidump file \a
+//!     location in \a file_reader, and returns it in \a dictionary.
+//!
+//! \return `true` on success, with \a dictionary set. `false` on failure, with
+//!     a message logged. If any individual strings cannot be read, or if any
+//!     duplicate keys are found, it is not considered an error, although a
+//!     message will be logged.
+bool ReadMinidumpSimpleStringDictionary(
+    FileReaderInterface* file_reader,

[Robert Sesek, 2015/02/19 15:13:19]

Is it worth a note that the file_reader offset will remain unchanged? I'm not
clear why it's necessary to restore the SEEK_CUR though.

[Mark Mentovai, 2015/02/26 18:43:03]

Robert Sesek wrote:
I’m getting rid of all of the restoration stuff. I thought it might be useful,
but it’s just becoming pervasive, so I’m leaving it out until it proves itself
necessary, and even then it’l probably be better handled via a scoper.

+    const MINIDUMP_LOCATION_DESCRIPTOR& location,
+    std::map<std::string, std::string>* dictionary);

[Robert Sesek, 2015/02/19 15:13:19]

No requirement for empty on entry? (Maybe not because this will be used to
aggregate all annotations from the process and the modules, but then how will we
deal with duplicate keys?).

+
+}  // namespace internal
+}  // namespace crashpad
+
+#endif  // CRASHPAD_SNAPSHOT_MINIDUMP_MINIDUMP_SIMPLE_STRING_DICTIONARY_READER_H_