Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1542)

Unified Diff: content/browser/indexed_db/indexed_db_database_error.h

Issue 932143003: IndexedDB: Report QuotaExceededError when commit fails due to disk full (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Document ignored transactions Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/indexed_db/indexed_db_database_error.h
diff --git a/content/browser/indexed_db/indexed_db_database_error.h b/content/browser/indexed_db/indexed_db_database_error.h
index 25b5ea6ed1cc81cae9614027aa8bd3d4bb3804e1..302378eff44e3d9cebb95f736e14fd23d82aad07 100644
--- a/content/browser/indexed_db/indexed_db_database_error.h
+++ b/content/browser/indexed_db/indexed_db_database_error.h
@@ -14,6 +14,7 @@ namespace content {
class IndexedDBDatabaseError {
public:
explicit IndexedDBDatabaseError(uint16 code) : code_(code) {}
+ IndexedDBDatabaseError() {}
cmumford 2015/02/20 17:50:17 What do you think about getting in the habit of on
jsbell 2015/02/20 18:27:02 Done. Moved all the impls to (a new) .cc file.
IndexedDBDatabaseError(uint16 code, const char* message)
: code_(code), message_(base::ASCIIToUTF16(message)) {}
IndexedDBDatabaseError(uint16 code, const base::string16& message)
@@ -24,10 +25,8 @@ class IndexedDBDatabaseError {
const base::string16& message() const { return message_; }
private:
- const uint16 code_;
- const base::string16 message_;
-
- DISALLOW_COPY_AND_ASSIGN(IndexedDBDatabaseError);
+ uint16 code_ = 0;
cmumford 2015/02/20 17:50:17 yeah! I forgot this is now allowed.
+ base::string16 message_;
};
} // namespace content
« no previous file with comments | « content/browser/indexed_db/indexed_db_browsertest.cc ('k') | content/browser/indexed_db/indexed_db_transaction.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698