sort_sources.py: Document limitations

sort_sources.py: Document limitations

Along the way, add r prefix to regex patterns.

BUG=456014
TEST=N/A

Committed: https://crrev.com/2f612699fe7d332d9c870e9d6801a083629877a2
Cr-Commit-Position: refs/heads/master@{#317193}

[satorux1, 2015-02-19 00:55:05]

satorux@chromium.org changed reviewers:
+ derat@chromium.org

[Daniel Erat, 2015-02-19 14:05:17]

lgtm with a few comments

https://codereview.chromium.org/932133005/diff/20001/tools/sort_sources.py
File tools/sort_sources.py (right):

https://codereview.chromium.org/932133005/diff/20001/tools/sort_sources.py#ne...
tools/sort_sources.py:46: interprets a blank line as the end of a source list.
hmm, it may not be possible to always do this. i think i had problems recently
with GN having a presubmit check that complained about me trying to put a blank
line above a comment in the middle of a file list.

https://codereview.chromium.org/932133005/diff/20001/tools/sort_sources.py#ne...
tools/sort_sources.py:71: next line ("d.cc",). This kind of errors should be
fixed manually.
maybe you should say that the fix is to not check in commented-out code. :-)

[satorux1, 2015-02-20 00:00:59]

New patchsets have been uploaded after l-g-t-m from derat@chromium.org

[satorux1, 2015-02-20 00:14:29]

https://codereview.chromium.org/932133005/diff/20001/tools/sort_sources.py
File tools/sort_sources.py (right):

https://codereview.chromium.org/932133005/diff/20001/tools/sort_sources.py#ne...
tools/sort_sources.py:46: interprets a blank line as the end of a source list.
On 2015/02/19 14:05:17, Daniel Erat wrote:
> hmm, it may not be possible to always do this. i think i had problems recently
> with GN having a presubmit check that complained about me trying to put a
blank
> line above a comment in the middle of a file list.

It should be OK. Here's from ash/BUILD.gn:

     # TODO(zork): fix this test to build on Windows. See: crosbug.com/26906
      "focus_cycler_unittest.cc",

      # All tests for multiple displays: not supported on Windows Ash.
      "wm/drag_window_resizer_unittest.cc",


However, gn format doesn't like a blank line without a following comment.

https://codereview.chromium.org/932133005/diff/20001/tools/sort_sources.py#ne...
tools/sort_sources.py:71: next line ("d.cc",). This kind of errors should be
fixed manually.
On 2015/02/19 14:05:17, Daniel Erat wrote:
> maybe you should say that the fix is to not check in commented-out code. :-)

good point. added.

[satorux1, 2015-02-20 00:14:47]

The CQ bit was checked by satorux@chromium.org

[commit-bot: I haz the power, 2015-02-20 00:16:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/932133005/60001

[commit-bot: I haz the power, 2015-02-20 00:37:10]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-02-20 00:37:51]

Patchset 4 (id:??) landed as
https://crrev.com/2f612699fe7d332d9c870e9d6801a083629877a2
Cr-Commit-Position: refs/heads/master@{#317193}