Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 932113002: Revive quad approximation stroker (Closed)

Created:
5 years, 10 months ago by caryclark
Modified:
5 years, 10 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

This uses quad approximations of the outer and inner paths describing a stroke. Cubics and conics' thick strokes are approximated with quads as well. The approximation uses a similar error term as the fill scan converter to determine the number of quads to use. This also updates SampleApp QuadStroker test with conics, ovals, and stroked text. Committed: https://skia.googlesource.com/skia/+/04e4d08556750ff6be4576a4cd4925964c63376f

Patch Set 1 #

Patch Set 2 : remove sampleapp changes #

Patch Set 3 : add conic support #

Patch Set 4 : add conic support to experimental stroking #

Patch Set 5 : adjust error term; add circle test #

Patch Set 6 : remove unneeded stuff from sample #

Patch Set 7 : add macro to suppress uninitialized warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+368 lines, -124 lines) Patch
M gyp/common.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M samplecode/SampleQuadStroker.cpp View 1 2 3 4 5 18 chunks +138 lines, -37 lines 0 comments Download
M src/core/SkStroke.h View 1 2 3 4 3 chunks +1 line, -13 lines 0 comments Download
M src/core/SkStroke.cpp View 1 2 3 4 5 6 36 chunks +219 lines, -72 lines 0 comments Download
M src/core/SkStrokeRec.cpp View 1 2 3 4 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
caryclark
5 years, 10 months ago (2015-02-18 21:15:58 UTC) #2
caryclark
5 years, 10 months ago (2015-02-19 18:08:40 UTC) #3
reed1
lgtm
5 years, 10 months ago (2015-02-19 22:25:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/932113002/100001
5 years, 10 months ago (2015-02-20 13:49:03 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot/builds/2166)
5 years, 10 months ago (2015-02-20 13:50:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/932113002/120001
5 years, 10 months ago (2015-02-20 14:20:03 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 14:34:01 UTC) #12
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/04e4d08556750ff6be4576a4cd4925964c63376f

Powered by Google App Engine
This is Rietveld 408576698