Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: sky/examples/stocks/stock.sky

Issue 932103004: Make the stock app demo list view prettier (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/examples/stocks/stock-arrow.sky » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/examples/stocks/stock.sky
diff --git a/sky/examples/stocks/stock.sky b/sky/examples/stocks/stock.sky
index 9bc505185de8e8dfa0d916af587f4715e97bf0a8..71261f6f11839f1ec3b9647504c4b5f9fb44afb0 100644
--- a/sky/examples/stocks/stock.sky
+++ b/sky/examples/stocks/stock.sky
@@ -4,6 +4,7 @@
// found in the LICENSE file.
-->
<import src="/sky/framework/sky-element.sky" />
+<import src="stock-arrow.sky" />
<sky-element>
<template>
@@ -13,71 +14,36 @@
// height: 48px;
max-height: 48px;
display: flex;
+ align-items: center;
border-bottom: 1px solid #F4F4F4;
padding-top: 16px;
padding-left: 16px;
padding-right: 16px;
padding-bottom: 20px;
}
+ stock-arrow {
+ margin-right: 16px;
+ }
#ticker {
- flex-grow: 1;
+ flex: 1;
+ font-family: 'Roboto Medium', 'Helvetica';
}
#last-sale {
- padding-right: 20px;
+ text-align: right;
+ padding-right: 16px;
}
#change {
- border-radius: 5px;
- min-width: 72px;
- padding: 2px;
- padding-right: 10px;
+ color: #8A8A8A;
text-align: right;
}
</style>
+ <stock-arrow id="arrow" />
<div id="ticker" />
<div id="last-sale" />
<div id="change" />
</template>
<script>
import "dart:sky";
-import "dart:math";
-
-List<String> redColors = [
- '#FFEBEE',
- '#FFCDD2',
- '#EF9A9A',
- '#E57373',
- '#EF5350',
- '#F44336',
- '#E53935',
- '#D32F2F',
- '#C62828',
- '#B71C1C',
-];
-
-List<String> greenColors = [
- '#E8F5E9',
- '#C8E6C9',
- '#A5D6A7',
- '#81C784',
- '#66BB6A',
- '#4CAF50',
- '#43A047',
- '#388E3C',
- '#2E7D32',
- '#1B5E20',
-];
-
-int colorIndexForPercentChange(double percentChange) {
- // Currently the max is 10%.
- double maxPercent = 10.0;
- return max(0, ((percentChange.abs() / maxPercent) * greenColors.length).floor());
-}
-
-String colorForPercentChange(double percentChange) {
- if (percentChange > 0)
- return greenColors[colorIndexForPercentChange(percentChange)];
- return redColors[colorIndexForPercentChange(percentChange)];
-}
@Tagname('stock')
class Stock extends SkyElement {
@@ -94,7 +60,9 @@ class Stock extends SkyElement {
if (model.percentChange > 0)
changeString = "+" + changeString;
change.textContent = changeString;
- change.style['background-color'] = colorForPercentChange(model.percentChange);
+
+ StockArrow arrow = shadowRoot.getElementById('arrow');
+ arrow.change = model.percentChange;
}
}
« no previous file with comments | « no previous file | sky/examples/stocks/stock-arrow.sky » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698