Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 932103003: Add support for more param traits in ipc fuzzer (Closed)

Created:
5 years, 10 months ago by inferno
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for more param traits R=mbarbella@chromium.org TBR=tsepez@chromium.org BUG=450268 Committed: https://crrev.com/eb016f0d649ae395fa7d2d7d8633c788eaa6985a Cr-Commit-Position: refs/heads/master@{#316902}

Patch Set 1 #

Total comments: 2

Patch Set 2 : generate random value for type #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -5 lines) Patch
M tools/ipc_fuzzer/mutate/generate.cc View 1 3 chunks +30 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Martin Barbella
lgtm https://codereview.chromium.org/932103003/diff/1/tools/ipc_fuzzer/mutate/generate.cc File tools/ipc_fuzzer/mutate/generate.cc (right): https://codereview.chromium.org/932103003/diff/1/tools/ipc_fuzzer/mutate/generate.cc#newcode1045 tools/ipc_fuzzer/mutate/generate.cc:1045: info.type = (blink::WebCursorInfo::Type)(RandInRange(44)); Can we use the last ...
5 years, 10 months ago (2015-02-18 20:08:02 UTC) #1
Tom Sepez
lgtm https://codereview.chromium.org/932103003/diff/1/tools/ipc_fuzzer/mutate/generate.cc File tools/ipc_fuzzer/mutate/generate.cc (right): https://codereview.chromium.org/932103003/diff/1/tools/ipc_fuzzer/mutate/generate.cc#newcode1045 tools/ipc_fuzzer/mutate/generate.cc:1045: info.type = (blink::WebCursorInfo::Type)(RandInRange(44)); On 2015/02/18 20:08:02, mbarbella wrote: ...
5 years, 10 months ago (2015-02-18 20:17:11 UTC) #2
Martin Barbella
On 2015/02/18 20:17:11, Tom Sepez wrote: > lgtm > > https://codereview.chromium.org/932103003/diff/1/tools/ipc_fuzzer/mutate/generate.cc > File tools/ipc_fuzzer/mutate/generate.cc (right): ...
5 years, 10 months ago (2015-02-18 20:18:59 UTC) #3
Martin Barbella
lgtm
5 years, 10 months ago (2015-02-18 21:35:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/932103003/40001
5 years, 10 months ago (2015-02-18 21:35:44 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 10 months ago (2015-02-18 22:11:20 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 22:12:06 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eb016f0d649ae395fa7d2d7d8633c788eaa6985a
Cr-Commit-Position: refs/heads/master@{#316902}

Powered by Google App Engine
This is Rietveld 408576698