Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 932023002: Use the correct title for the bookmark app bubble. (Closed)

Created:
5 years, 10 months ago by benwells
Modified:
5 years, 10 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the correct title for the bookmark app bubble. It should be be updated for each platform, in the same way the menu item to bring it up is. BUG=447384 Committed: https://crrev.com/2ff465698398eaa458103444c705d750888846a0 Cr-Commit-Position: refs/heads/master@{#316901}

Patch Set 1 #

Patch Set 2 : Fix mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -8 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +21 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/bookmark_app_bubble_view.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc View 1 4 chunks +19 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
benwells
5 years, 10 months ago (2015-02-18 07:20:22 UTC) #2
Lei Zhang
lgtm
5 years, 10 months ago (2015-02-18 20:29:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/932023002/20001
5 years, 10 months ago (2015-02-18 20:55:33 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-18 22:00:52 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 22:01:14 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/2ff465698398eaa458103444c705d750888846a0
Cr-Commit-Position: refs/heads/master@{#316901}

Powered by Google App Engine
This is Rietveld 408576698