Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 932013004: Make use_goma=true also work for Mac GN. (Closed)

Created:
5 years, 10 months ago by Yoshisato Yanagisawa
Modified:
5 years, 10 months ago
CC:
chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make use_goma=true also work for Mac GN. Since toolchain/mac/BUILD.gn did not have anything to support use_goma, even if use_goma=true set, the flags was just ignored. BUG=459435 Committed: https://crrev.com/874b8fe5991b4f57088f3ff4218cc8e8acd2b18d Cr-Commit-Position: refs/heads/master@{#316758}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M build/toolchain/mac/BUILD.gn View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Yoshisato Yanagisawa
Hi, I found gn --args=use_goma=true is ignored on mac build. Let me make use_goma also ...
5 years, 10 months ago (2015-02-18 02:45:50 UTC) #2
Nico
lgtm
5 years, 10 months ago (2015-02-18 02:54:23 UTC) #3
scottmg
The linux one uses compiler_prefix, rather than goma_prefix. Maybe would be better to be consistent, ...
5 years, 10 months ago (2015-02-18 02:55:16 UTC) #4
Dirk Pranke
that might explain a few things ... :). lgtm also.
5 years, 10 months ago (2015-02-18 02:55:35 UTC) #7
Yoshisato Yanagisawa
I saw both linux/BUILD.gn and win/BUILD.gn. Linux uses compiler_prefix and Windows uses goma_prefix. Since I ...
5 years, 10 months ago (2015-02-18 03:00:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/932013004/1
5 years, 10 months ago (2015-02-18 03:00:59 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-18 03:18:50 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 03:19:56 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/874b8fe5991b4f57088f3ff4218cc8e8acd2b18d
Cr-Commit-Position: refs/heads/master@{#316758}

Powered by Google App Engine
This is Rietveld 408576698