Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 932003005: gpu: Remove gpu_bindings.h inclusion from headers and reduce includes dependencies. (Closed)

Created:
5 years, 10 months ago by Daniele Castagna
Modified:
5 years, 10 months ago
Reviewers:
reveman, piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Remove gpu_bindings.h inclusion from headers and reduce includes dependencies. BUG= Committed: https://crrev.com/64ae265e13ea6f211f8a1201047be69941cf857f Cr-Commit-Position: refs/heads/master@{#316986}

Patch Set 1 #

Patch Set 2 : Add include logging to measurements.cc and s/uint/unsigned int/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M gpu/command_buffer/service/gpu_timing.h View 1 2 chunks +5 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/gpu_timing.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gpu_tracer.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gpu_tracer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/perftests/measurements.h View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/perftests/measurements.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/perftests/texture_upload_perftest.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Daniele Castagna
5 years, 10 months ago (2015-02-18 03:29:23 UTC) #2
reveman
lgtm
5 years, 10 months ago (2015-02-18 03:59:37 UTC) #4
Daniele Castagna
5 years, 10 months ago (2015-02-18 18:52:11 UTC) #6
piman
lgtm
5 years, 10 months ago (2015-02-18 22:47:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/932003005/40001
5 years, 10 months ago (2015-02-18 22:50:19 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_rel_tests_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_rel_tests_recipe/builds/3161)
5 years, 10 months ago (2015-02-19 00:40:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/932003005/40001
5 years, 10 months ago (2015-02-19 02:48:29 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 10 months ago (2015-02-19 03:40:25 UTC) #14
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 03:41:28 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/64ae265e13ea6f211f8a1201047be69941cf857f
Cr-Commit-Position: refs/heads/master@{#316986}

Powered by Google App Engine
This is Rietveld 408576698