Index: chrome/browser/image_decoder.cc |
diff --git a/chrome/browser/image_decoder.cc b/chrome/browser/image_decoder.cc |
index 2f9e83b7ab8953f41eb2d5a4bfc091e8f7e81ce7..563820c88e0d93de30407f2cdd5c93dfb3587322 100644 |
--- a/chrome/browser/image_decoder.cc |
+++ b/chrome/browser/image_decoder.cc |
@@ -13,38 +13,136 @@ |
using content::BrowserThread; |
using content::UtilityProcessHost; |
-ImageDecoder::ImageDecoder(Delegate* delegate, |
- const std::string& image_data, |
- ImageCodec image_codec) |
- : delegate_(delegate), |
- image_data_(image_data.begin(), image_data.end()), |
- image_codec_(image_codec), |
- task_runner_(NULL), |
- shrink_to_fit_(false) { |
-} |
- |
-ImageDecoder::ImageDecoder(Delegate* delegate, |
- const std::vector<char>& image_data, |
- ImageCodec image_codec) |
- : delegate_(delegate), |
- image_data_(image_data.begin(), image_data.end()), |
- image_codec_(image_codec), |
- task_runner_(NULL), |
- shrink_to_fit_(false) { |
-} |
- |
-ImageDecoder::~ImageDecoder() {} |
- |
-void ImageDecoder::Start(scoped_refptr<base::SequencedTaskRunner> task_runner) { |
- task_runner_ = task_runner; |
+// static, Leaky to allow access from any thread. |
+base::LazyInstance<ImageDecoder>::Leaky image_decoder_instance_ = |
+ LAZY_INSTANCE_INITIALIZER; |
+ |
+// static |
+ImageDecoder* ImageDecoder::GetInstance() { |
+ return image_decoder_instance_.Pointer(); |
+} |
+ |
+ImageDecoder::ImageDecoder() : image_decoder_impl_(new ImageDecoderImpl()) { |
+} |
+ |
+ImageDecoder::~ImageDecoder() { |
+} |
+ |
+ImageDecoder::Delegate::Delegate( |
+ const scoped_refptr<base::SequencedTaskRunner>& t) |
+ : t(t) { |
+} |
+ |
+ImageDecoder::Delegate::~Delegate() { |
dcheng
2015/03/20 00:14:45
Call RemoveDelegate(this) here. Deleting this shou
Theresa
2015/03/20 19:09:01
Done.
|
+} |
+ |
+void ImageDecoder::Start(Delegate* delegate, |
+ const std::string& image_data, |
+ ImageCodec image_codec, |
+ bool shrink_to_fit) { |
+ DCHECK(delegate); |
+ DCHECK(delegate->task_runner()); |
+ BrowserThread::PostTask( |
+ BrowserThread::IO, FROM_HERE, |
+ base::Bind( |
+ &ImageDecoder::ImageDecoderImpl::DecodeImageInSandbox, |
+ GetInstance()->image_decoder_impl_, delegate, |
+ std::vector<unsigned char>(image_data.begin(), image_data.end()), |
+ image_codec, shrink_to_fit)); |
+} |
+ |
+void ImageDecoder::RemoveDelegate(Delegate* delegate) { |
BrowserThread::PostTask( |
- BrowserThread::IO, FROM_HERE, |
- base::Bind(&ImageDecoder::DecodeImageInSandbox, this, image_data_)); |
+ BrowserThread::IO, FROM_HERE, |
+ base::Bind(&ImageDecoder::ImageDecoderImpl::RemoveDelegate, |
+ GetInstance()->image_decoder_impl_, delegate)); |
+} |
+ |
+// ImageDecoder::ImageDecoderImpl Methods |
+ |
+ImageDecoder::ImageDecoderImpl::ImageDecoderImpl() |
+ : delegate_id_counter_(0), |
+ last_request_(base::TimeTicks::Now()), |
+ batch_mode_started_(false) { |
+} |
+ |
+ImageDecoder::ImageDecoderImpl::~ImageDecoderImpl() { |
} |
-bool ImageDecoder::OnMessageReceived(const IPC::Message& message) { |
+void ImageDecoder::ImageDecoderImpl::DecodeImageInSandbox( |
+ Delegate* delegate, |
+ const std::vector<unsigned char>& image_data, |
+ ImageCodec image_codec, |
+ bool shrink_to_fit) { |
+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO)); |
+ if (!batch_mode_started_) { |
+ StartBatchMode(); |
+ } |
+ |
+ last_request_ = base::TimeTicks::Now(); |
+ delegate_id_map_.AddWithID(delegate, delegate_id_counter_); |
+ |
+ switch (image_codec) { |
+ case ROBUST_JPEG_CODEC: |
+ utility_process_host_->Send(new ChromeUtilityMsg_RobustJPEGDecodeImage( |
+ image_data, delegate_id_counter_)); |
+ break; |
+ case DEFAULT_CODEC: |
+ utility_process_host_->Send(new ChromeUtilityMsg_DecodeImage( |
+ image_data, shrink_to_fit, delegate_id_counter_)); |
+ break; |
+ default: |
+ NOTREACHED(); |
+ } |
+ |
+ ++delegate_id_counter_; |
+} |
+ |
+void ImageDecoder::ImageDecoderImpl::RemoveDelegate(Delegate* delegate) { |
+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO)); |
+ std::vector<int> canceled_requests; |
+ |
+ for (IDMap<Delegate>::iterator iter(&delegate_id_map_); !iter.IsAtEnd(); |
+ iter.Advance()) { |
+ if (iter.GetCurrentValue() == delegate) { |
+ canceled_requests.push_back(iter.GetCurrentKey()); |
+ } |
+ } |
+ |
+ for (auto id : canceled_requests) { |
+ delegate_id_map_.Remove(id); |
+ } |
+} |
+ |
+void ImageDecoder::ImageDecoderImpl::StartBatchMode() { |
+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO)); |
+ utility_process_host_ = |
+ UtilityProcessHost::Create(this, base::MessageLoopProxy::current().get()) |
+ ->AsWeakPtr(); |
+ utility_process_host_->StartBatchMode(); |
+ batch_mode_started_ = true; |
+ batch_mode_timer_.Start(FROM_HERE, kBatchModeTimeout, this, |
+ &ImageDecoder::ImageDecoderImpl::StopBatchMode); |
+} |
+ |
+void ImageDecoder::ImageDecoderImpl::StopBatchMode() { |
+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO)); |
+ if ((base::TimeTicks::Now() - last_request_) < kBatchModeTimeout) { |
+ return; |
+ } |
+ |
+ if (utility_process_host_) { |
+ utility_process_host_->EndBatchMode(); |
+ utility_process_host_.reset(); |
+ } |
+ batch_mode_started_ = false; |
+ batch_mode_timer_.Stop(); |
+} |
+ |
+bool ImageDecoder::ImageDecoderImpl::OnMessageReceived( |
+ const IPC::Message& message) { |
bool handled = true; |
- IPC_BEGIN_MESSAGE_MAP(ImageDecoder, message) |
+ IPC_BEGIN_MESSAGE_MAP(ImageDecoder::ImageDecoderImpl, message) |
IPC_MESSAGE_HANDLER(ChromeUtilityHostMsg_DecodeImage_Succeeded, |
OnDecodeImageSucceeded) |
IPC_MESSAGE_HANDLER(ChromeUtilityHostMsg_DecodeImage_Failed, |
@@ -54,28 +152,28 @@ bool ImageDecoder::OnMessageReceived(const IPC::Message& message) { |
return handled; |
} |
-void ImageDecoder::OnDecodeImageSucceeded(const SkBitmap& decoded_image) { |
- DCHECK(task_runner_->RunsTasksOnCurrentThread()); |
- if (delegate_) |
- delegate_->OnImageDecoded(this, decoded_image); |
-} |
+void ImageDecoder::ImageDecoderImpl::OnDecodeImageSucceeded( |
+ const SkBitmap& decoded_image, |
+ int id) { |
+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO)); |
+ if (delegate_id_map_.Lookup(id)) { |
+ Delegate* delegate = delegate_id_map_.Lookup(id); |
+ delegate->task_runner()->PostTask( |
+ FROM_HERE, base::Bind(&Delegate::OnImageDecoded, |
+ base::Unretained(delegate), decoded_image)); |
-void ImageDecoder::OnDecodeImageFailed() { |
- DCHECK(task_runner_->RunsTasksOnCurrentThread()); |
- if (delegate_) |
- delegate_->OnDecodeImageFailed(this); |
+ delegate_id_map_.Remove(id); |
+ } |
} |
-void ImageDecoder::DecodeImageInSandbox( |
- const std::vector<unsigned char>& image_data) { |
+void ImageDecoder::ImageDecoderImpl::OnDecodeImageFailed(int id) { |
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO)); |
- UtilityProcessHost* utility_process_host; |
- utility_process_host = UtilityProcessHost::Create(this, task_runner_.get()); |
- if (image_codec_ == ROBUST_JPEG_CODEC) { |
- utility_process_host->Send( |
- new ChromeUtilityMsg_RobustJPEGDecodeImage(image_data)); |
- } else { |
- utility_process_host->Send( |
- new ChromeUtilityMsg_DecodeImage(image_data, shrink_to_fit_)); |
+ if (delegate_id_map_.Lookup(id)) { |
+ Delegate* delegate = delegate_id_map_.Lookup(id); |
+ delegate->task_runner()->PostTask( |
+ FROM_HERE, |
+ base::Bind(&Delegate::OnDecodeImageFailed, base::Unretained(delegate))); |
+ |
+ delegate_id_map_.Remove(id); |
} |
} |