Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: chrome/browser/image_decoder.h

Issue 931993002: Make image_decoder a Leaky LazyInstance (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix a couple more build issues Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/image_decoder.h
diff --git a/chrome/browser/image_decoder.h b/chrome/browser/image_decoder.h
index 2206dd9f454ebcbfc3a29674cf41e1d42eb594ee..b1b22e358ddf3bcb40ccadc49f178b2dfc9a0eee 100644
--- a/chrome/browser/image_decoder.h
+++ b/chrome/browser/image_decoder.h
@@ -15,7 +15,9 @@
class SkBitmap;
-// Decodes an image in a sandboxed process.
+// Decodes an image in a sandboxed process. This class is deprecated and will be
+// removed once crbug.com/<TODO(twellington): fill this in once deprecation is
+// approved and bug is created> is resolved. Use ImageBatchDecoder instead.
class ImageDecoder : public content::UtilityProcessHostClient {
public:
class Delegate {
@@ -66,8 +68,8 @@ class ImageDecoder : public content::UtilityProcessHostClient {
bool OnMessageReceived(const IPC::Message& message) override;
// IPC message handlers.
- void OnDecodeImageSucceeded(const SkBitmap& decoded_image);
- void OnDecodeImageFailed();
+ void OnDecodeImageSucceeded(const SkBitmap& decoded_image, int id);
+ void OnDecodeImageFailed(int id);
// Launches sandboxed process that will decode the image.
void DecodeImageInSandbox(const std::vector<unsigned char>& image_data);

Powered by Google App Engine
This is Rietveld 408576698