chrome/browser/extensions/api/webstore_private/webstore_private_api.cc - Issue 931993002: Make image_decoder a Leaky LazyInstance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

Issue 931993002: Make image_decoder a Leaky LazyInstance (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add ImageDecoder->RemoveDelegate Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/login/users/avatar/user_image_loader.cc ('K') | « chrome/browser/chromeos/login/users/avatar/user_image_manager_test_util.cc ('k') | chrome/browser/extensions/bundle_installer.cc » ('j') | chrome/browser/image_decoder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

diff --git a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

index 902011de02e7cf846fd7a2b14de91bb887e666fc..86171d5283f1d6bcc34283862eb70b9e748d71df 100644

--- a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

+++ b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

@@ -262,9 +262,6 @@ WebstorePrivateFunctionWithPermissionPrompt<Params>::Run() {

}

- std::string icon_data = params_->details.icon_data ?

- *params_->details.icon_data : std::string();

ExtensionFunction::ResponseValue response = RunExtraForResponse();

if (response)

return RespondNow(response.Pass());

@@ -274,7 +271,7 @@ WebstorePrivateFunctionWithPermissionPrompt<Params>::Run() {

context_getter = browser_context()->GetRequestContext();

scoped_refptr<WebstoreInstallHelper> helper = new WebstoreInstallHelper(

- this, params_->details.id, params_->details.manifest, icon_data, icon_url,

+ this, params_->details.id, params_->details.manifest, icon_url,

context_getter);

// The helper will call us back via OnWebstoreParseSuccess or