Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Unified Diff: chrome/browser/chromeos/app_mode/kiosk_app_data.cc

Issue 931993002: Make image_decoder a Leaky LazyInstance (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add ImageDecoder->RemoveDelegate Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/app_mode/kiosk_app_data.cc
diff --git a/chrome/browser/chromeos/app_mode/kiosk_app_data.cc b/chrome/browser/chromeos/app_mode/kiosk_app_data.cc
index af29edac943f459ecd0bcea887a279dc0328157e..76e5a44a67113ebb630b2f1597695e753bd3b57d 100644
--- a/chrome/browser/chromeos/app_mode/kiosk_app_data.cc
+++ b/chrome/browser/chromeos/app_mode/kiosk_app_data.cc
@@ -232,9 +232,9 @@ class KioskAppData::IconLoader : public ImageDecoder::Delegate {
}
raw_icon_ = base::RefCountedString::TakeString(&data);
- scoped_refptr<ImageDecoder> image_decoder = new ImageDecoder(
- this, raw_icon_->data(), ImageDecoder::DEFAULT_CODEC);
- image_decoder->Start(task_runner_);
+ ImageDecoder::GetInstance()->Start(this, raw_icon_->data(),
+ ImageDecoder::DEFAULT_CODEC,
+ task_runner_, false);
}
void ReportResultOnBlockingPool(LoadResult result) {
@@ -266,14 +266,13 @@ class KioskAppData::IconLoader : public ImageDecoder::Delegate {
}
// ImageDecoder::Delegate overrides:
- void OnImageDecoded(const ImageDecoder* decoder,
- const SkBitmap& decoded_image) override {
+ void OnImageDecoded(const SkBitmap& decoded_image) override {
icon_ = gfx::ImageSkia::CreateFrom1xBitmap(decoded_image);
icon_.MakeThreadSafe();
ReportResultOnBlockingPool(SUCCESS);
}
- void OnDecodeImageFailed(const ImageDecoder* decoder) override {
+ void OnDecodeImageFailed() override {
ReportResultOnBlockingPool(FAILED_TO_DECODE);
}
@@ -307,7 +306,6 @@ class KioskAppData::WebstoreDataParser
new extensions::WebstoreInstallHelper(this,
app_id,
manifest,
- "", // No icon data.
icon_url,
context_getter);
webstore_helper->Start();

Powered by Google App Engine
This is Rietveld 408576698