chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.h - Issue 931993002: Make image_decoder a Leaky LazyInstance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.h

Issue 931993002: Make image_decoder a Leaky LazyInstance (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Small changes based on review from Antony Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/logo_service.cc ('K') | « chrome/browser/chromeos/login/screens/user_image_screen.cc ('k') | chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.h

diff --git a/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.h b/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.h

index a41cd6dff3c693f5630f764abcb4f94294dea71e..544cb3f971c97c0c7c03ef80e1f12eeaaaca21ad 100644

--- a/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.h

+++ b/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.h

@@ -117,9 +117,8 @@ class SupervisedUserCreationScreen

const std::string& image_type) override;

void OnImageAccepted() override;

// ImageDecoder::Delegate overrides:

- void OnImageDecoded(const ImageDecoder* decoder,

- const SkBitmap& decoded_image) override;

- void OnDecodeImageFailed(const ImageDecoder* decoder) override;

+ void OnImageDecoded(const SkBitmap& decoded_image) override;

+ void OnDecodeImageFailed() override;

private:

void ApplyPicture();

@@ -137,7 +136,6 @@ class SupervisedUserCreationScreen

SupervisedUserSyncService* sync_service_;

gfx::ImageSkia user_photo_;

- scoped_refptr<ImageDecoder> image_decoder_;

bool apply_photo_after_decoding_;

int selected_image_;