Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3489)

Unified Diff: chrome/browser/chromeos/app_mode/kiosk_app_data.cc

Issue 931993002: Make image_decoder a Leaky LazyInstance (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rename instance_ to image_decoder_instance_ for mac linker Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/app_mode/kiosk_app_data.cc
diff --git a/chrome/browser/chromeos/app_mode/kiosk_app_data.cc b/chrome/browser/chromeos/app_mode/kiosk_app_data.cc
index 93b45f374faa078f3b088bc515d9223e49acd2d0..f6f90b9e21da17ddd08b05f5319cb6643a8ba067 100644
--- a/chrome/browser/chromeos/app_mode/kiosk_app_data.cc
+++ b/chrome/browser/chromeos/app_mode/kiosk_app_data.cc
@@ -232,9 +232,8 @@ class KioskAppData::IconLoader : public ImageDecoder::Delegate {
}
raw_icon_ = base::RefCountedString::TakeString(&data);
- scoped_refptr<ImageDecoder> image_decoder = new ImageDecoder(
- this, raw_icon_->data(), ImageDecoder::DEFAULT_CODEC);
- image_decoder->Start(task_runner_);
+ ImageDecoder::GetInstance()->Start(
+ this, raw_icon_->data(), ImageDecoder::DEFAULT_CODEC, task_runner_);
}
void ReportResultOnBlockingPool(LoadResult result) {
@@ -266,14 +265,13 @@ class KioskAppData::IconLoader : public ImageDecoder::Delegate {
}
// ImageDecoder::Delegate overrides:
- void OnImageDecoded(const ImageDecoder* decoder,
- const SkBitmap& decoded_image) override {
+ void OnImageDecoded(const SkBitmap& decoded_image) override {
icon_ = gfx::ImageSkia::CreateFrom1xBitmap(decoded_image);
icon_.MakeThreadSafe();
ReportResultOnBlockingPool(SUCCESS);
}
- void OnDecodeImageFailed(const ImageDecoder* decoder) override {
+ void OnDecodeImageFailed() override {
ReportResultOnBlockingPool(FAILED_TO_DECODE);
}

Powered by Google App Engine
This is Rietveld 408576698