Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: chrome/browser/enhanced_bookmarks/android/bookmark_image_service_android.cc

Issue 931993002: Make image_decoder a Leaky LazyInstance (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix a couple more build issues Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/json/json_parser.h" 5 #include "base/json/json_parser.h"
6 #include "base/strings/utf_string_conversions.h" 6 #include "base/strings/utf_string_conversions.h"
7 #include "base/values.h" 7 #include "base/values.h"
8 #include "chrome/browser/bitmap_fetcher/bitmap_fetcher.h" 8 #include "chrome/browser/bitmap_fetcher/bitmap_batch_fetcher.h"
9 #include "chrome/browser/enhanced_bookmarks/android/bookmark_image_service_andro id.h" 9 #include "chrome/browser/enhanced_bookmarks/android/bookmark_image_service_andro id.h"
10 #include "chrome/browser/enhanced_bookmarks/enhanced_bookmark_model_factory.h" 10 #include "chrome/browser/enhanced_bookmarks/enhanced_bookmark_model_factory.h"
11 #include "chrome/grit/browser_resources.h" 11 #include "chrome/grit/browser_resources.h"
12 #include "components/bookmarks/browser/bookmark_model.h" 12 #include "components/bookmarks/browser/bookmark_model.h"
13 #include "components/enhanced_bookmarks/enhanced_bookmark_model.h" 13 #include "components/enhanced_bookmarks/enhanced_bookmark_model.h"
14 #include "content/public/browser/browser_context.h" 14 #include "content/public/browser/browser_context.h"
15 #include "content/public/browser/browser_thread.h" 15 #include "content/public/browser/browser_thread.h"
16 #include "content/public/browser/navigation_entry.h" 16 #include "content/public/browser/navigation_entry.h"
17 #include "content/public/browser/render_frame_host.h" 17 #include "content/public/browser/render_frame_host.h"
18 #include "content/public/browser/web_contents.h" 18 #include "content/public/browser/web_contents.h"
(...skipping 24 matching lines...) Expand all
43 bool update_bookmark) { 43 bool update_bookmark) {
44 const BookmarkNode* bookmark = 44 const BookmarkNode* bookmark =
45 enhanced_bookmark_model_->bookmark_model() 45 enhanced_bookmark_model_->bookmark_model()
46 ->GetMostRecentlyAddedUserNodeForURL(page_url); 46 ->GetMostRecentlyAddedUserNodeForURL(page_url);
47 if (!bookmark || !image_url.is_valid()) { 47 if (!bookmark || !image_url.is_valid()) {
48 ProcessNewImage(page_url, update_bookmark, gfx::Image(), image_url); 48 ProcessNewImage(page_url, update_bookmark, gfx::Image(), image_url);
49 return; 49 return;
50 } 50 }
51 51
52 BitmapFetcherHandler* bitmap_fetcher_handler = 52 BitmapFetcherHandler* bitmap_fetcher_handler =
53 new BitmapFetcherHandler(this, image_url); 53 new BitmapFetcherHandler(this);
54 bitmap_fetcher_handler->Start( 54 bitmap_fetcher_handler->Start(
55 browser_context_, referrer, referrer_policy, 55 browser_context_, referrer, referrer_policy,
56 net::LOAD_DO_NOT_SEND_COOKIES | net::LOAD_DO_NOT_SAVE_COOKIES, 56 net::LOAD_DO_NOT_SEND_COOKIES | net::LOAD_DO_NOT_SAVE_COOKIES,
57 update_bookmark, page_url); 57 update_bookmark, page_url,
58 bitmap_batch_fetcher_,
59 image_url);
58 } 60 }
59 61
60 void BookmarkImageServiceAndroid::RetrieveSalientImageFromContext( 62 void BookmarkImageServiceAndroid::RetrieveSalientImageFromContext(
61 content::RenderFrameHost* render_frame_host, 63 content::RenderFrameHost* render_frame_host,
62 const GURL& page_url, 64 const GURL& page_url,
63 bool update_bookmark) { 65 bool update_bookmark) {
64 DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI)); 66 DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
65 if (IsPageUrlInProgress(page_url)) 67 if (IsPageUrlInProgress(page_url))
66 return; // A request for this URL is already in progress. 68 return; // A request for this URL is already in progress.
67 69
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 RetrieveSalientImage(page_url, GURL(image_url), referrer.url.spec(), 185 RetrieveSalientImage(page_url, GURL(image_url), referrer.url.spec(),
184 referrer_policy, update_bookmark); 186 referrer_policy, update_bookmark);
185 } 187 }
186 188
187 void BookmarkImageServiceAndroid::BitmapFetcherHandler::Start( 189 void BookmarkImageServiceAndroid::BitmapFetcherHandler::Start(
188 content::BrowserContext* browser_context, 190 content::BrowserContext* browser_context,
189 const std::string& referrer, 191 const std::string& referrer,
190 net::URLRequest::ReferrerPolicy referrer_policy, 192 net::URLRequest::ReferrerPolicy referrer_policy,
191 int load_flags, 193 int load_flags,
192 bool update_bookmark, 194 bool update_bookmark,
193 const GURL& page_url) { 195 const GURL& page_url,
196 chrome::BitmapBatchFetcher& bitmap_batch_fetcher,
197 const GURL& image_url) {
198
194 update_bookmark_ = update_bookmark; 199 update_bookmark_ = update_bookmark;
195 page_url_ = page_url; 200 page_url_ = page_url;
196 201
197 bitmap_fetcher_.Start(browser_context->GetRequestContext(), referrer, 202 bitmap_batch_fetcher.Start(browser_context->GetRequestContext(), referrer,
198 referrer_policy, load_flags); 203 referrer_policy, load_flags,
204 image_url,
205 this);
199 } 206 }
200 207
201 void BookmarkImageServiceAndroid::BitmapFetcherHandler::OnFetchComplete( 208 void BookmarkImageServiceAndroid::BitmapFetcherHandler::OnFetchComplete(
202 const GURL url, 209 const GURL url,
203 const SkBitmap* bitmap) { 210 const SkBitmap* bitmap) {
204 DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI)); 211 DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
205 212
206 gfx::Image image; 213 gfx::Image image;
207 if (bitmap) { 214 if (bitmap) {
208 gfx::ImageSkia imageSkia = gfx::ImageSkia::CreateFrom1xBitmap(*bitmap); 215 gfx::ImageSkia imageSkia = gfx::ImageSkia::CreateFrom1xBitmap(*bitmap);
209 imageSkia.MakeThreadSafe(); 216 imageSkia.MakeThreadSafe();
210 image = gfx::Image(imageSkia); 217 image = gfx::Image(imageSkia);
211 } 218 }
212 service_->ProcessNewImage(page_url_, update_bookmark_, image, url); 219 service_->ProcessNewImage(page_url_, update_bookmark_, image, url);
213 220
214 delete this; 221 delete this;
215 } 222 }
216 223
217 } // namespace enhanced_bookmarks 224 } // namespace enhanced_bookmarks
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698