Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 931873002: Delete sky/services/inspector/server.cc. (Closed)

Created:
5 years, 10 months ago by ppi
Modified:
5 years, 10 months ago
CC:
esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Delete sky/services/inspector/server.cc. Sky Inspector is currently not working. This patch removes the Inspector server, which is based on net/http_server, to unblock dropping /net in Mojo. BUG=456130 R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0d0de5b6af208f0847e7af7931805e5d1a4bf930

Patch Set 1 #

Total comments: 1

Patch Set 2 : Drop the InspectorServer interface and inspector_impl. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -257 lines) Patch
M sky/services/inspector/BUILD.gn View 1 chunk +0 lines, -18 lines 0 comments Download
M sky/services/inspector/inspector.mojom View 1 1 chunk +0 lines, -4 lines 0 comments Download
D sky/services/inspector/server.cc View 1 chunk +0 lines, -154 lines 0 comments Download
M sky/viewer/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
D sky/viewer/services/inspector_impl.h View 1 1 chunk +0 lines, -35 lines 0 comments Download
D sky/viewer/services/inspector_impl.cc View 1 1 chunk +0 lines, -44 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ppi
Hi Adam or Eric, ptal.
5 years, 10 months ago (2015-02-17 16:23:28 UTC) #2
abarth-chromium
lgtm https://codereview.chromium.org/931873002/diff/1/sky/services/inspector/BUILD.gn File sky/services/inspector/BUILD.gn (right): https://codereview.chromium.org/931873002/diff/1/sky/services/inspector/BUILD.gn#newcode15 sky/services/inspector/BUILD.gn:15: "inspector.mojom", You should delete the mojom too.
5 years, 10 months ago (2015-02-17 16:24:58 UTC) #3
ppi
Thanks. In ps2 I delete the InspectorServer interface, and transitively also InspectorServiceImpl that refers to ...
5 years, 10 months ago (2015-02-17 16:41:11 UTC) #5
abarth-chromium
On 2015/02/17 at 16:41:11, ppi wrote: > Thanks. In ps2 I delete the InspectorServer interface, ...
5 years, 10 months ago (2015-02-17 17:14:26 UTC) #6
abarth-chromium
lgtm
5 years, 10 months ago (2015-02-17 17:14:38 UTC) #7
ppi
5 years, 10 months ago (2015-02-17 17:18:38 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0d0de5b6af208f0847e7af7931805e5d1a4bf930 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698