Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 931793002: bindings: Fixes potential build breakage (V8DOMConfiguration::installAccessor). (Closed)

Created:
5 years, 10 months ago by Yuki
Modified:
5 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

bindings: Fixes potential build breakage (V8DOMConfiguration::installAccessor). The arguments of the call to V8DOMConfiguration::installAccessor in interface_base.cpp was wrong. This CL Fixes it. Since the code is not yet actually used, we failed to detect the error. BUG=43394 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190391

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/bindings/templates/interface_base.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Yuki
Could you review this CL?
5 years, 10 months ago (2015-02-17 10:45:34 UTC) #2
haraken
LGTM
5 years, 10 months ago (2015-02-17 10:56:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931793002/1
5 years, 10 months ago (2015-02-17 11:19:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/43233)
5 years, 10 months ago (2015-02-17 13:14:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931793002/1
5 years, 10 months ago (2015-02-18 04:22:24 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 05:21:07 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190391

Powered by Google App Engine
This is Rietveld 408576698