Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 931783002: bindings: Fixes battery-status test (attributes are not own properties). (Closed)

Created:
5 years, 10 months ago by Yuki
Modified:
5 years, 10 months ago
Reviewers:
haraken, jsbell
CC:
blink-reviews, mlamouri+watch-blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

bindings: Fixes battery-status test (attributes are not own properties). The current battery-status/api-defined.html assumes that the attributes are own properties, which is wrong. Removes wrong assumptions. The test still tests the existence of the attributes by using expressions in the form of "attribute" in battery BUG=43394 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190342

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M LayoutTests/battery-status/api-defined.html View 2 chunks +1 line, -6 lines 0 comments Download
M LayoutTests/battery-status/api-defined-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Yuki
Could you guys review this CL?
5 years, 10 months ago (2015-02-17 10:19:04 UTC) #2
timvolodine
On 2015/02/17 10:19:04, Yuki wrote: > Could you guys review this CL? Hi Yuki, why ...
5 years, 10 months ago (2015-02-17 10:37:59 UTC) #3
Yuki
On 2015/02/17 10:37:59, timvolodine wrote: > On 2015/02/17 10:19:04, Yuki wrote: > > Could you ...
5 years, 10 months ago (2015-02-17 10:48:42 UTC) #4
haraken
LGTM
5 years, 10 months ago (2015-02-17 10:55:49 UTC) #5
jsbell
lgtm
5 years, 10 months ago (2015-02-17 18:12:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931783002/1
5 years, 10 months ago (2015-02-17 18:14:59 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 18:21:19 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190342

Powered by Google App Engine
This is Rietveld 408576698