Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 931723002: Add perf tests for animations using different CSS value types (Closed)

Created:
5 years, 10 months ago by alancutter (OOO until 2018)
Modified:
5 years, 10 months ago
Reviewers:
sullivan, shans, qyearsley
CC:
chromium-reviews, telemetry-reviews_chromium.org, blink-reviews-animation_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add perf tests for animations using different CSS value types This adds perf tests for CSS and Web Animations over the following CSS value types: - Color - Filter - Length - Length 3D - Shadow - Transform BUG=309981 Committed: https://crrev.com/0f604440fa0d538d402a4213152ee6a48fd97ad1 Cr-Commit-Position: refs/heads/master@{#316677}

Patch Set 1 #

Patch Set 2 : #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+252 lines, -2 lines) Patch
M tools/perf/page_sets/tough_animation_cases.py View 1 1 chunk +47 lines, -0 lines 0 comments Download
A tools/perf/page_sets/tough_animation_cases/css_value_type_color.html View 1 chunk +15 lines, -0 lines 0 comments Download
A tools/perf/page_sets/tough_animation_cases/css_value_type_filter.html View 1 chunk +15 lines, -0 lines 0 comments Download
A tools/perf/page_sets/tough_animation_cases/css_value_type_length_3d.html View 1 chunk +20 lines, -0 lines 0 comments Download
A tools/perf/page_sets/tough_animation_cases/css_value_type_length_complex.html View 1 chunk +20 lines, -0 lines 0 comments Download
A tools/perf/page_sets/tough_animation_cases/css_value_type_length_simple.html View 1 chunk +20 lines, -0 lines 0 comments Download
A tools/perf/page_sets/tough_animation_cases/css_value_type_shadow.html View 1 chunk +15 lines, -0 lines 0 comments Download
A tools/perf/page_sets/tough_animation_cases/css_value_type_transform_complex.html View 1 chunk +15 lines, -0 lines 0 comments Download
A tools/perf/page_sets/tough_animation_cases/css_value_type_transform_simple.html View 1 chunk +15 lines, -0 lines 0 comments Download
A tools/perf/page_sets/tough_animation_cases/resources/css_value_type.js View 1 chunk +56 lines, -0 lines 2 comments Download
M tools/perf/page_sets/tough_animation_cases/resources/perftesthelper.js View 1 chunk +14 lines, -2 lines 2 comments Download

Messages

Total messages: 11 (4 generated)
alancutter (OOO until 2018)
5 years, 10 months ago (2015-02-17 02:00:24 UTC) #2
sullivan
lgtm https://codereview.chromium.org/931723002/diff/20001/tools/perf/page_sets/tough_animation_cases/resources/css_value_type.js File tools/perf/page_sets/tough_animation_cases/resources/css_value_type.js (right): https://codereview.chromium.org/931723002/diff/20001/tools/perf/page_sets/tough_animation_cases/resources/css_value_type.js#newcode14 tools/perf/page_sets/tough_animation_cases/resources/css_value_type.js:14: console.assert(document.getElementById('container')); Are these left in intentionally because they ...
5 years, 10 months ago (2015-02-17 14:30:31 UTC) #4
qyearsley
https://codereview.chromium.org/931723002/diff/20001/tools/perf/page_sets/tough_animation_cases/resources/perftesthelper.js File tools/perf/page_sets/tough_animation_cases/resources/perftesthelper.js (right): https://codereview.chromium.org/931723002/diff/20001/tools/perf/page_sets/tough_animation_cases/resources/perftesthelper.js#newcode4 tools/perf/page_sets/tough_animation_cases/resources/perftesthelper.js:4: (function(){ [Optional] You could also make this file match ...
5 years, 10 months ago (2015-02-17 17:51:40 UTC) #6
alancutter (OOO until 2018)
Thanks for the reviews. https://codereview.chromium.org/931723002/diff/20001/tools/perf/page_sets/tough_animation_cases/resources/css_value_type.js File tools/perf/page_sets/tough_animation_cases/resources/css_value_type.js (right): https://codereview.chromium.org/931723002/diff/20001/tools/perf/page_sets/tough_animation_cases/resources/css_value_type.js#newcode14 tools/perf/page_sets/tough_animation_cases/resources/css_value_type.js:14: console.assert(document.getElementById('container')); On 2015/02/17 14:30:31, sullivan ...
5 years, 10 months ago (2015-02-17 20:42:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931723002/20001
5 years, 10 months ago (2015-02-17 20:43:25 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-17 22:35:07 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 22:35:55 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0f604440fa0d538d402a4213152ee6a48fd97ad1
Cr-Commit-Position: refs/heads/master@{#316677}

Powered by Google App Engine
This is Rietveld 408576698