Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1411)

Unified Diff: net/base/net_util_unittest.cc

Issue 9317018: referrer_charset is a lie. It's really the user's default_charset. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/net_util.cc ('k') | net/http/http_content_disposition.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/net_util_unittest.cc
===================================================================
--- net/base/net_util_unittest.cc (revision 119865)
+++ net/base/net_util_unittest.cc (working copy)
@@ -45,7 +45,7 @@
struct FileNameCDCase {
const char* header_field;
- const char* referrer_charset;
+ const char* default_charset;
const wchar_t* expected;
};
@@ -387,7 +387,7 @@
struct GenerateFilenameCase {
const char* url;
const char* content_disp_header;
- const char* referrer_charset;
+ const char* default_charset;
const char* suggested_filename;
const char* mime_type;
const wchar_t* default_filename;
@@ -516,7 +516,7 @@
std::string default_filename(WideToUTF8(test_case->default_filename));
FilePath file_path = GenerateFileName(
GURL(test_case->url), test_case->content_disp_header,
- test_case->referrer_charset, test_case->suggested_filename,
+ test_case->default_charset, test_case->suggested_filename,
test_case->mime_type, default_filename);
EXPECT_EQ(test_case->expected_filename,
file_util::FilePathAsWString(file_path))
@@ -2091,7 +2091,7 @@
for (size_t i = 0; i < ARRAYSIZE_UNSAFE(generation_tests); ++i) {
GenerateFilenameCase test_case = generation_tests[i];
- test_case.referrer_charset = "GBK";
+ test_case.default_charset = "GBK";
RunGenerateFileNameTestCase(&test_case, i, "generation (referrer=GBK)");
}
}
« no previous file with comments | « net/base/net_util.cc ('k') | net/http/http_content_disposition.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698