Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 931673002: Improve GrInOrderDrawBuffer::Cmd encapsulation (Closed)

Created:
5 years, 10 months ago by robertphillips
Modified:
5 years, 10 months ago
Reviewers:
joshualitt, joshua.litt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Improve GrInOrderDrawBuffer::Cmd encapsulation In preparation for moving all the Cmds out of GrInOrderDrawBuffer. Committed: https://skia.googlesource.com/skia/+/e5e72f1fbfa02522f30762d7d8ad07a6f9add5d9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -33 lines) Patch
M src/gpu/GrInOrderDrawBuffer.h View 1 chunk +20 lines, -10 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 9 chunks +11 lines, -23 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
robertphillips
5 years, 10 months ago (2015-02-16 19:03:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931673002/1
5 years, 10 months ago (2015-02-16 19:03:25 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-16 19:03:26 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
5 years, 10 months ago (2015-02-17 01:03:28 UTC) #7
joshualitt
On 2015/02/17 01:03:28, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
5 years, 10 months ago (2015-02-17 14:48:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931673002/1
5 years, 10 months ago (2015-02-17 17:14:28 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 17:14:37 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e5e72f1fbfa02522f30762d7d8ad07a6f9add5d9

Powered by Google App Engine
This is Rietveld 408576698