Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 931663007: Disable delaying of Apps installation on Chrome OS for first time sign-in (Closed)

Created:
5 years, 10 months ago by binjin
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Andrew T Wilson (Slow), Dmitry Polukhin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable delaying of Apps installation on Chrome OS for first time sign-in This behavior is introduced by a772ed62ff0641df984feffe977b1545e94d53f1. It makes ExternalPrefLoader not being ready when user sign in to Chromebook for the first time and accidentally blocks all installation of external extensions if Chrome Sync is turned off, including force installed extensions by policy. BUG=457539 TEST=manual Committed: https://crrev.com/9a5194c07bd95febb99e61cdaaf9e42e602bd0be Cr-Commit-Position: refs/heads/master@{#317074} Committed: https://crrev.com/c84cba82076843523c3cc3a05c781b370dda3a88 Cr-Commit-Position: refs/heads/master@{#317244}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M chrome/browser/extensions/external_provider_impl.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 17 (4 generated)
binjin
Nikita, Antony: Could you please have a look at this as reviewers of the original ...
5 years, 10 months ago (2015-02-19 14:44:06 UTC) #2
binjin
Just realized that Antony is OOO as well. Benjamin: Could you have a look at ...
5 years, 10 months ago (2015-02-19 15:15:48 UTC) #4
Nikita (slow)
lgtm
5 years, 10 months ago (2015-02-19 16:36:56 UTC) #5
not at google - send to devlin
lgtm, revert sounds like the right thing to do - are you planning on revising ...
5 years, 10 months ago (2015-02-19 17:28:54 UTC) #6
binjin
On 2015/02/19 17:28:54, kalman wrote: > lgtm, revert sounds like the right thing to do ...
5 years, 10 months ago (2015-02-19 17:50:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931663007/1
5 years, 10 months ago (2015-02-19 17:51:44 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-19 17:58:12 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9a5194c07bd95febb99e61cdaaf9e42e602bd0be Cr-Commit-Position: refs/heads/master@{#317074}
5 years, 10 months ago (2015-02-19 17:59:28 UTC) #11
Ken Russell (switch to Gerrit)
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/939183003/ by kbr@chromium.org. ...
5 years, 10 months ago (2015-02-20 01:42:47 UTC) #12
binjin
On 2015/02/20 01:42:47, Ken Russell wrote: > A revert of this CL (patchset #1 id:1) ...
5 years, 10 months ago (2015-02-20 04:42:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931663007/1
5 years, 10 months ago (2015-02-20 04:44:05 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 04:44:38 UTC) #16
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 04:45:18 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c84cba82076843523c3cc3a05c781b370dda3a88
Cr-Commit-Position: refs/heads/master@{#317244}

Powered by Google App Engine
This is Rietveld 408576698