Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 931653002: Fix path in components_tests.gyp to GN version of components_unittests (Closed)

Created:
5 years, 10 months ago by mstrum
Modified:
5 years, 10 months ago
Reviewers:
blundell
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix path in components_tests.gyp to GN version of components_unittests There was a typo where a '/' was used instead of a ':'. components_unittests is found in components/BUILD.gn. Committed: https://crrev.com/9f8fae1fae0003f5544f0888ac64408c33ed10bd Cr-Commit-Position: refs/heads/master@{#316582}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/components_tests.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
mstrum
PTAL
5 years, 10 months ago (2015-02-16 18:33:00 UTC) #2
blundell
lgtm
5 years, 10 months ago (2015-02-17 08:24:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931653002/1
5 years, 10 months ago (2015-02-17 16:21:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 16:40:11 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 16:40:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f8fae1fae0003f5544f0888ac64408c33ed10bd
Cr-Commit-Position: refs/heads/master@{#316582}

Powered by Google App Engine
This is Rietveld 408576698