Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 931643003: Improve accessibility for the bookmark app bubble. (Closed)

Created:
5 years, 10 months ago by benwells
Modified:
5 years, 10 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve accessibility for the bookmark app bubble. This change sets the accessibility state of the bubble correctly, and also adds an accessible name for the name edit. The question mark is also removed from the bubble title. BUG=363372 Committed: https://crrev.com/81ecb5a72f9f6fab01db20009ac2039bb80918fe Cr-Commit-Position: refs/heads/master@{#316636}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +12 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/extensions/bookmark_app_bubble_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc View 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
benwells
5 years, 10 months ago (2015-02-17 06:30:08 UTC) #2
Lei Zhang
lgtm
5 years, 10 months ago (2015-02-17 19:54:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931643003/1
5 years, 10 months ago (2015-02-17 19:55:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 20:00:01 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 20:00:55 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/81ecb5a72f9f6fab01db20009ac2039bb80918fe
Cr-Commit-Position: refs/heads/master@{#316636}

Powered by Google App Engine
This is Rietveld 408576698